feat: Impl InMemoryCatalog's UpdateTable

Author: WZhuo

src/iceberg/catalog/memory/in_memory_catalog.cc

@@ -21,8 +21,8 @@
 
 #include <algorithm>
 #include <iterator>
-#include <mutex>
 #include <memory>
+#include <mutex>
 
 #include "iceberg/table.h"
 #include "iceberg/table_identifier.h"

src/iceberg/table_metadata.cc

@@ -292,19 +292,17 @@ Result<std::unique_ptr<TableMetadata>> TableMetadataUtil::Read(
 }
 
 Status TableMetadataUtil::Write(FileIO& io, const TableMetadata* base,
-                                TableMetadata* metadata) {
-  ICEBERG_CHECK(metadata != nullptr, "The metadata is nullptr.");
-
+                                TableMetadata& metadata) {
   int version = -1;
   if (base != nullptr && !base->metadata_file_location.empty()) {
     // parse current version from location
     version = ParseVersionFromLocation(base->metadata_file_location);
   }
 
   ICEBERG_ASSIGN_OR_RAISE(std::string new_file_location,
-                          NewTableMetadataFilePath(*metadata, version + 1));
-  ICEBERG_RETURN_UNEXPECTED(Write(io, new_file_location, *metadata));
-  metadata->metadata_file_location = std::move(new_file_location);
+                          NewTableMetadataFilePath(metadata, version + 1));
+  ICEBERG_RETURN_UNEXPECTED(Write(io, new_file_location, metadata));
+  metadata.metadata_file_location = std::move(new_file_location);
   return {};
 }
 

src/iceberg/table_metadata.h

@@ -490,14 +490,13 @@ struct ICEBERG_EXPORT CodecTypeUtil {
   /// \return The file extension of the codec.
   static std::string CodecTypeToFileExtension(MetadataFileCodecType codec);
 
-  inline static constexpr std::string_view kTableMetadataFileSuffix = ".metadata.json";
-  inline static constexpr std::string_view kCompGzipTableMetadataFileSuffix =
+  static constexpr std::string_view kTableMetadataFileSuffix = ".metadata.json";
+  static constexpr std::string_view kCompGzipTableMetadataFileSuffix =
       ".metadata.json.gz";
-  inline static constexpr std::string_view kGzipTableMetadataFileSuffix =
-      ".gz.metadata.json";
-  inline static constexpr std::string_view kGzipTableMetadataFileExtension = ".gz";
-  inline static constexpr std::string_view kCodecTypeGzip = "GZIP";
-  inline static constexpr std::string_view kCodecTypeNone = "NONE";
+  static constexpr std::string_view kGzipTableMetadataFileSuffix = ".gz.metadata.json";
+  static constexpr std::string_view kGzipTableMetadataFileExtension = ".gz";
+  static constexpr std::string_view kCodecTypeGzip = "GZIP";
+  static constexpr std::string_view kCodecTypeNone = "NONE";
 };
 
 /// \brief Utility class for table metadata
@@ -521,7 +520,7 @@ struct ICEBERG_EXPORT TableMetadataUtil {
   /// \param io The FileIO instance for writing files
   /// \param base The base metadata (can be null for new tables)
   /// \param metadata The metadata to write, which will be updated with the new location
-  static Status Write(FileIO& io, const TableMetadata* base, TableMetadata* metadata);
+  static Status Write(FileIO& io, const TableMetadata* base, TableMetadata& metadata);
 
   /// \brief Delete removed metadata files based on retention policy.
   ///