Skip to content

Commit 9669237

Browse files
committed
fix: resolve signed/unsigned integer comparison warning
- Use static_cast<size_t>() to convert view_of_partition->length to unsigned type - Fixes modernize-use-integer-sign-comparison clang-tidy warning at line 375 - Safe conversion since Arrow array lengths are always non-negative
1 parent 76994af commit 9669237

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/iceberg/manifest_reader_internal.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -372,7 +372,8 @@ Status ParseDataFile(const std::shared_ptr<StructType>& data_file_schema,
372372
}
373373
if (view_of_file_field->n_children > 0) {
374374
auto view_of_partition = view_of_file_field->children[0];
375-
for (size_t row_idx = 0; row_idx < view_of_partition->length; row_idx++) {
375+
for (size_t row_idx = 0;
376+
row_idx < static_cast<size_t>(view_of_partition->length); row_idx++) {
376377
if (ArrowArrayViewIsNull(view_of_partition, row_idx)) {
377378
break;
378379
}

0 commit comments

Comments
 (0)