fix lint

Author: xiao.dong

src/iceberg/manifest_entry.h

@@ -297,12 +297,13 @@ struct ICEBERG_EXPORT ManifestEntry {
       SchemaField::MakeRequired(0, "status", iceberg::int32());
   inline static const SchemaField kSnapshotId =
       SchemaField::MakeOptional(1, "snapshot_id", iceberg::int64());
+  inline static const int32_t kDataFileFieldId = 2;
+  inline static const std::string kDataFileField = "data_file";
   inline static const SchemaField kSequenceNumber =
       SchemaField::MakeOptional(3, "sequence_number", iceberg::int64());
   inline static const SchemaField kFileSequenceNumber =
       SchemaField::MakeOptional(4, "file_sequence_number", iceberg::int64());
-  inline static const int32_t kDataFileFieldId = 2;
-  inline static const std::string kDataFileField = "data_file";
+
   bool operator==(const ManifestEntry& other) const;
 
   static std::shared_ptr<StructType> TypeFromPartitionType(

src/iceberg/partition_spec.cc

@@ -65,7 +65,7 @@ Result<std::shared_ptr<Schema>> PartitionSpec::partition_schema() {
     return nullptr;
   }
   {
-    std::lock_guard<std::mutex> lock(mutex_);
+    std::scoped_lock<std::mutex> lock(mutex_);
     if (partition_schema_ != nullptr) {
       return partition_schema_;
     }
@@ -96,7 +96,7 @@ Result<std::shared_ptr<Schema>> PartitionSpec::partition_schema() {
     );
   }
 
-  std::lock_guard<std::mutex> lock(mutex_);
+  std::scoped_lock<std::mutex> lock(mutex_);
   if (partition_schema_ == nullptr) {
     partition_schema_ = std::make_shared<Schema>(std::move(partition_fields));
   }