fix string util

Author: xiao.dong

src/iceberg/file_format.h

@@ -27,7 +27,7 @@
 
 #include "iceberg/iceberg_export.h"
 #include "iceberg/result.h"
-#include "iceberg/util/string_utils_internal.h"
+#include "iceberg/util/string_utils.h"
 
 namespace iceberg {
 
@@ -57,7 +57,7 @@ ICEBERG_EXPORT inline std::string_view ToString(FileFormatType format_type) {
 /// \brief Convert a string to a FileFormatType
 ICEBERG_EXPORT inline Result<FileFormatType> FileFormatTypeFromString(
     std::string_view str) noexcept {
-  auto lower = internal::StringUtils::ToLower(str);
+  auto lower = StringUtils::ToLower(str);
   if (lower == "parquet") return FileFormatType::kParquet;
   if (lower == "avro") return FileFormatType::kAvro;
   if (lower == "orc") return FileFormatType::kOrc;

src/iceberg/util/string_utils_internal.h renamed to src/iceberg/util/string_utils.h

@@ -25,17 +25,17 @@
 
 #include "iceberg/iceberg_export.h"
 
-namespace iceberg::internal {
+namespace iceberg {
 
-class StringUtils {
+class ICEBERG_EXPORT StringUtils {
  public:
   static std::string ToLower(std::string_view str) {
     std::string input(str);
     // TODO(xiao.dong) gcc 13.3 didn't support std::ranges::to
     std::transform(input.begin(), input.end(), input.begin(),  // NOLINT
                    [](char c) { return std::tolower(c); });    // NOLINT
     return input;
-  }  // namespace iceberg::internal
+  }
 
   static std::string ToUpper(std::string_view str) {
     std::string input(str);
@@ -46,4 +46,4 @@ class StringUtils {
   }
 };
 
-}  // namespace iceberg::internal
+}  // namespace iceberg

test/string_utils_test.cc

@@ -17,28 +17,28 @@
  * under the License.
  */
 
-#include <gtest/gtest.h>
+#include "iceberg/util/string_utils.h"
 
-#include "iceberg/util/string_utils_internal.h"
+#include <gtest/gtest.h>
 
 namespace iceberg {
 
 TEST(StringUtilsTest, ToLower) {
-  ASSERT_EQ(internal::StringUtils::ToLower("AbC"), "abc");
-  ASSERT_EQ(internal::StringUtils::ToLower("A-bC"), "a-bc");
-  ASSERT_EQ(internal::StringUtils::ToLower("A_bC"), "a_bc");
-  ASSERT_EQ(internal::StringUtils::ToLower(""), "");
-  ASSERT_EQ(internal::StringUtils::ToLower(" "), " ");
-  ASSERT_EQ(internal::StringUtils::ToLower("123"), "123");
+  ASSERT_EQ(StringUtils::ToLower("AbC"), "abc");
+  ASSERT_EQ(StringUtils::ToLower("A-bC"), "a-bc");
+  ASSERT_EQ(StringUtils::ToLower("A_bC"), "a_bc");
+  ASSERT_EQ(StringUtils::ToLower(""), "");
+  ASSERT_EQ(StringUtils::ToLower(" "), " ");
+  ASSERT_EQ(StringUtils::ToLower("123"), "123");
 }
 
 TEST(StringUtilsTest, ToUpper) {
-  ASSERT_EQ(internal::StringUtils::ToUpper("abc"), "ABC");
-  ASSERT_EQ(internal::StringUtils::ToUpper("A-bC"), "A-BC");
-  ASSERT_EQ(internal::StringUtils::ToUpper("A_bC"), "A_BC");
-  ASSERT_EQ(internal::StringUtils::ToUpper(""), "");
-  ASSERT_EQ(internal::StringUtils::ToUpper(" "), " ");
-  ASSERT_EQ(internal::StringUtils::ToUpper("123"), "123");
+  ASSERT_EQ(StringUtils::ToUpper("abc"), "ABC");
+  ASSERT_EQ(StringUtils::ToUpper("A-bC"), "A-BC");
+  ASSERT_EQ(StringUtils::ToUpper("A_bC"), "A_BC");
+  ASSERT_EQ(StringUtils::ToUpper(""), "");
+  ASSERT_EQ(StringUtils::ToUpper(" "), " ");
+  ASSERT_EQ(StringUtils::ToUpper("123"), "123");
 }
 
 }  // namespace iceberg