Skip to content

Commit a88d681

Browse files
author
nullccxsy
committed
fix review
1 parent 54f4ccc commit a88d681

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

src/iceberg/file_reader.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ class ICEBERG_EXPORT Reader {
5555
/// \brief Get the schema of the data.
5656
virtual Result<ArrowSchema> Schema() = 0;
5757

58-
/// \brief Get the metadata of the file
58+
/// \brief Get the metadata of the file.
5959
virtual Result<std::unordered_map<std::string, std::string>> Metadata() = 0;
6060
};
6161

src/iceberg/parquet/parquet_reader.cc

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -202,11 +202,7 @@ class ParquetReader::Impl {
202202
}
203203

204204
std::unordered_map<std::string, std::string> metadata_map;
205-
metadata_map.reserve(kv_metadata->size());
206-
207-
for (int i = 0; i < kv_metadata->size(); ++i) {
208-
metadata_map.insert_or_assign(kv_metadata->key(i), kv_metadata->value(i));
209-
}
205+
kv_metadata->ToUnorderedMap(&metadata_map);
210206

211207
return metadata_map;
212208
}

0 commit comments

Comments
 (0)