Skip to content

Commit b606110

Browse files
committed
feat: Impl InMemoryCatalog's UpdateTable
1 parent f48e2e6 commit b606110

File tree

3 files changed

+6
-8
lines changed

3 files changed

+6
-8
lines changed

src/iceberg/catalog/memory/in_memory_catalog.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@
2121

2222
#include <algorithm>
2323
#include <iterator>
24-
#include <mutex>
2524
#include <memory>
25+
#include <mutex>
2626

2727
#include "iceberg/table.h"
2828
#include "iceberg/table_identifier.h"

src/iceberg/table_metadata.cc

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -292,19 +292,17 @@ Result<std::unique_ptr<TableMetadata>> TableMetadataUtil::Read(
292292
}
293293

294294
Status TableMetadataUtil::Write(FileIO& io, const TableMetadata* base,
295-
TableMetadata* metadata) {
296-
ICEBERG_CHECK(metadata != nullptr, "The metadata is nullptr.");
297-
295+
TableMetadata& metadata) {
298296
int version = -1;
299297
if (base != nullptr && !base->metadata_file_location.empty()) {
300298
// parse current version from location
301299
version = ParseVersionFromLocation(base->metadata_file_location);
302300
}
303301

304302
ICEBERG_ASSIGN_OR_RAISE(std::string new_file_location,
305-
NewTableMetadataFilePath(*metadata, version + 1));
306-
ICEBERG_RETURN_UNEXPECTED(Write(io, new_file_location, *metadata));
307-
metadata->metadata_file_location = std::move(new_file_location);
303+
NewTableMetadataFilePath(metadata, version + 1));
304+
ICEBERG_RETURN_UNEXPECTED(Write(io, new_file_location, metadata));
305+
metadata.metadata_file_location = std::move(new_file_location);
308306
return {};
309307
}
310308

src/iceberg/table_metadata.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -521,7 +521,7 @@ struct ICEBERG_EXPORT TableMetadataUtil {
521521
/// \param io The FileIO instance for writing files
522522
/// \param base The base metadata (can be null for new tables)
523523
/// \param metadata The metadata to write, which will be updated with the new location
524-
static Status Write(FileIO& io, const TableMetadata* base, TableMetadata* metadata);
524+
static Status Write(FileIO& io, const TableMetadata* base, TableMetadata& metadata);
525525

526526
/// \brief Delete removed metadata files based on retention policy.
527527
///

0 commit comments

Comments
 (0)