cpp-linter complains about unnamed namespaces in header files

Signed-off-by: Junwang Zhao <[email protected]>

Author: zhjwpku

src/iceberg/arrow/arrow_error_transform_internal.h

@@ -27,8 +27,6 @@
 
 namespace iceberg::arrow::internal {
 
-namespace {
-
 inline ErrorKind ToErrorKind(const ::arrow::Status& status) {
   switch (status.code()) {
     case ::arrow::StatusCode::IOError:
@@ -46,8 +44,6 @@ inline ErrorKind ToErrorKind(const ::arrow::Status& status) {
   }                                                                                      \
   lhs = std::move(result_name).ValueOrDie();
 
-}  // namespace
-
 #define ICEBERG_INTERNAL_ASSIGN_OR_RETURN(lhs, rexpr)                       \
   ICEBERG_INTERNAL_ASSIGN_OR_RETURN_IMPL(                                   \
       ARROW_ASSIGN_OR_RAISE_NAME(_error_or_value, __COUNTER__), lhs, rexpr, \

src/iceberg/arrow/io/arrow_fs_file_io.cc

@@ -50,12 +50,10 @@ expected<std::string, Error> ArrowFileSystemFileIO::ReadFile(
 expected<void, Error> ArrowFileSystemFileIO::WriteFile(const std::string& file_location,
                                                        std::string_view content,
                                                        bool overwrite) {
-  // auto file_info = arrow_fs_->GetFileInfo(file_location);
-  // if (file_info.status().ok() && !overwrite) {
-  //   return unexpected(
-  //       Error(ErrorKind::kAlreadyExists, std::format("File {} exists",
-  //       file_location)));
-  // }
+  auto exists = arrow_fs_->OpenInputFile(file_location).ok();
+  if (!overwrite && exists) {
+    return unexpected(Error(ErrorKind::kAlreadyExists, "File already exists"));
+  }
   ICEBERG_INTERNAL_ASSIGN_OR_RETURN(auto file,
                                     arrow_fs_->OpenOutputStream(file_location));
   ICEBERG_INTERNAL_RETURN_NOT_OK(file->Write(content.data(), content.size()));

test/CMakeLists.txt

@@ -42,7 +42,8 @@ if(ICEBERG_BUILD_BUNDLE)
 
   add_executable(arrow_test)
   target_sources(arrow_test PRIVATE arrow_test.cc)
-  target_link_libraries(arrow_test PRIVATE iceberg_bundle_static GTest::gtest_main)
+  target_link_libraries(arrow_test PRIVATE iceberg_bundle_static GTest::gtest_main
+                                           GTest::gmock)
   add_test(NAME arrow_test COMMAND arrow_test)
 
   add_executable(arrow_fs_file_io_test)