remove MSVC_TOOLCHAIN

Author: wgtmac

CMakeLists.txt

@@ -33,13 +33,6 @@ set(CMAKE_CXX_STANDARD_REQUIRED ON)
 set(CMAKE_CXX_EXTENSIONS OFF)
 set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
 
-if(WIN32 AND NOT MINGW)
-  # This is used to handle builds using e.g. clang in an MSVC setting.
-  set(MSVC_TOOLCHAIN TRUE)
-else()
-  set(MSVC_TOOLCHAIN FALSE)
-endif()
-
 option(ICEBERG_BUILD_STATIC "Build static library" ON)
 option(ICEBERG_BUILD_SHARED "Build shared library" OFF)
 option(ICEBERG_BUILD_TESTS "Build tests" ON)

cmake_modules/BuildUtils.cmake

@@ -162,13 +162,7 @@ function(ADD_ICEBERG_LIB LIB_NAME)
       target_include_directories(${LIB_NAME}_static PRIVATE ${ARG_PRIVATE_INCLUDES})
     endif()
 
-    # if(MSVC_TOOLCHAIN)
-    #   set(LIB_NAME_STATIC ${LIB_NAME}_static)
-    # else()
-    set(LIB_NAME_STATIC ${LIB_NAME})
-    # endif()
-
-    set_target_properties(${LIB_NAME}_static PROPERTIES OUTPUT_NAME ${LIB_NAME_STATIC})
+    set_target_properties(${LIB_NAME}_static PROPERTIES OUTPUT_NAME ${LIB_NAME})
 
     if(ARG_STATIC_INSTALL_INTERFACE_LIBS)
       target_link_libraries(${LIB_NAME}_static