Skip to content

Commit bafed12

Browse files
author
xiao.dong
committed
remove useless virtual define
1 parent 74f17e3 commit bafed12

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

src/iceberg/manifest_adapter.h

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ class ICEBERG_EXPORT ManifestAdapter {
4646
Status StartAppending();
4747
Result<std::shared_ptr<ArrowArray>> FinishAppending();
4848
int64_t size() const { return size_; }
49-
virtual const std::shared_ptr<Schema>& schema() const = 0;
5049

5150
protected:
5251
static Status AppendField(ArrowArray* arrowArray, int64_t value);
@@ -72,7 +71,7 @@ class ICEBERG_EXPORT ManifestEntryAdapter : public ManifestAdapter {
7271

7372
virtual Status Append(const ManifestEntry& entry) = 0;
7473

75-
const std::shared_ptr<Schema>& schema() const override { return manifest_schema_; }
74+
const std::shared_ptr<Schema>& schema() const { return manifest_schema_; }
7675

7776
protected:
7877
virtual Result<std::shared_ptr<StructType>> GetManifestEntryStructType();
@@ -123,7 +122,7 @@ class ICEBERG_EXPORT ManifestFileAdapter : public ManifestAdapter {
123122

124123
virtual Status Append(const ManifestFile& file) = 0;
125124

126-
const std::shared_ptr<Schema>& schema() const override { return manifest_list_schema_; }
125+
const std::shared_ptr<Schema>& schema() const { return manifest_list_schema_; }
127126

128127
protected:
129128
/// \brief Init version-specific schema for each version.

0 commit comments

Comments
 (0)