Skip to content

Commit bffcd4e

Browse files
author
shuxu.li
committed
feat: transactional UpdateProperties method support
1 parent 37775fe commit bffcd4e

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/iceberg/base_transaction.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,9 +79,9 @@ class ICEBERG_EXPORT BaseTransaction : public Transaction {
7979
private:
8080
struct TransactionContext {
8181
TransactionContext() = default;
82-
TransactionContext(const TableIdentifier& identifier,
82+
TransactionContext(TableIdentifier identifier,
8383
std::shared_ptr<TableMetadata> metadata)
84-
: identifier(identifier), current_metadata(std::move(metadata)) {}
84+
: identifier(std::move(identifier)), current_metadata(std::move(metadata)) {}
8585

8686
TransactionContext(const TransactionContext&) = delete;
8787
TransactionContext& operator=(const TransactionContext&) = delete;

src/iceberg/test/base_transaction_test.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ TEST_F(BaseTransactionTest, RemovePropertiesSkipsMissingKeys) {
102102
dynamic_cast<const table::RemoveProperties*>(updates.front().get());
103103
EXPECT_NE(remove_update, nullptr);
104104
EXPECT_THAT(remove_update->removed(),
105-
::testing::ElementsAre("existing", "missing"));
105+
::testing::UnorderedElementsAre("missing", "existing"));
106106
return {std::unique_ptr<Table>()};
107107
});
108108

0 commit comments

Comments
 (0)