Skip to content

Commit c46ff60

Browse files
committed
continue resolve comments
1 parent 56c265e commit c46ff60

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

src/iceberg/expression/literal.h

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,16 @@ class ICEBERG_EXPORT Literal {
109109
/// and should not be AboveMax or BelowMin.
110110
std::partial_ordering operator<=>(const Literal& other) const;
111111

112+
/// Check if this literal represents a value above the maximum allowed value
113+
/// for its type. This occurs when casting from a wider type to a narrower type
114+
/// and the value exceeds the target type's maximum.
115+
/// \return true if this literal represents an AboveMax value, false otherwise
112116
bool IsAboveMax() const;
117+
118+
/// Check if this literal represents a value below the minimum allowed value
119+
/// for its type. This occurs when casting from a wider type to a narrower type
120+
/// and the value is less than the target type's minimum.
121+
/// \return true if this literal represents a BelowMin value, false otherwise
113122
bool IsBelowMin() const;
114123

115124
std::string ToString() const;

0 commit comments

Comments
 (0)