Skip to content

Commit cbf7d93

Browse files
committed
try to fix windows ci
1 parent 34bbf7d commit cbf7d93

File tree

1 file changed

+14
-0
lines changed

1 file changed

+14
-0
lines changed

cmake_modules/IcebergThirdpartyToolchain.cmake

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -205,6 +205,11 @@ endif()
205205
# It is also possible to vendor nanoarrow using the bundled source code.
206206
function(resolve_nanoarrow_dependency)
207207
prepare_fetchcontent()
208+
209+
set(NANOARROW_NAMESPACE
210+
"iceberg"
211+
CACHE STRING "" FORCE)
212+
208213
fetchcontent_declare(nanoarrow
209214
${FC_DECLARE_COMMON_OPTIONS}
210215
URL "https://dlcdn.apache.org/arrow/apache-arrow-nanoarrow-0.6.0/apache-arrow-nanoarrow-0.6.0.tar.gz"
@@ -232,6 +237,11 @@ function(resolve_sparrow_dependency)
232237
# include could not find requested file: sanitizers
233238
list(PREPEND CMAKE_MODULE_PATH ${CMAKE_CURRENT_BINARY_DIR}/_deps/sparrow-src/cmake)
234239

240+
if(MSVC_TOOLCHAIN)
241+
# MSVC does not support int128_t
242+
set(USE_LARGE_INT_PLACEHOLDERS ON)
243+
endif()
244+
235245
fetchcontent_declare(sparrow
236246
${FC_DECLARE_COMMON_OPTIONS}
237247
GIT_REPOSITORY https://github.com/man-group/sparrow.git
@@ -240,6 +250,10 @@ function(resolve_sparrow_dependency)
240250
fetchcontent_makeavailable(sparrow)
241251

242252
set_target_properties(sparrow PROPERTIES OUTPUT_NAME "iceberg_vendored_sparrow")
253+
target_compile_definitions(sparrow INTERFACE SPARROW_USE_DATE_POLYFILL)
254+
if(MSVC_TOOLCHAIN)
255+
target_compile_definitions(sparrow INTERFACE SPARROW_USE_LARGE_INT_PLACEHOLDERS)
256+
endif()
243257
install(TARGETS sparrow
244258
EXPORT iceberg_targets
245259
RUNTIME DESTINATION "${ICEBERG_INSTALL_BINDIR}"

0 commit comments

Comments
 (0)