Skip to content

Commit ce130f6

Browse files
committed
Improve PGP key instructions in release guide
1 parent 6604cbe commit ce130f6

File tree

2 files changed

+15
-8
lines changed

2 files changed

+15
-8
lines changed

.github/workflows/rc.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,10 +49,10 @@ jobs:
4949
5050
- name: Archive
5151
run: |
52-
id="apache-iceberg-cpp-${VERSION}-rc${RC}"
53-
tar_gz="${id}.tar.gz"
52+
ARCHIVE_FILE_NAME="apache-iceberg-cpp-${VERSION}-rc${RC}"
53+
tar_gz="${ARCHIVE_FILE_NAME}.tar.gz"
5454
echo "TAR_GZ=${tar_gz}" >> ${GITHUB_ENV}
55-
git archive HEAD --prefix "${id}/" --output "${tar_gz}"
55+
git archive HEAD --prefix "${ARCHIVE_FILE_NAME}/" --output "${tar_gz}"
5656
sha512sum "${tar_gz}" > "${tar_gz}.sha512"
5757
5858
- name: Audit

dev/release/README.md

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -53,20 +53,27 @@ Requirements to run `release_rc.sh`:
5353
If you don't have a PGP key, https://infra.apache.org/release-signing.html#generate
5454
may be helpful.
5555

56-
Your PGP key must be registered to the following:
56+
Your PGP key must be published in the KEYS file, which is hosted at:
5757

5858
* https://downloads.apache.org/iceberg/KEYS
5959

6060
See the header comment of them for how to add a PGP key.
6161

62-
Apache Iceberg committers can update them by Subversion client with their ASF account.
63-
e.g.:
62+
If you are a first-time release manager, you need to add your public key to this file. To prevent formatting errors, please use the following commands instead of editing the file manually:
63+
64+
+ Check out the release distribution directory:
6465

6566
```console
6667
$ svn co https://dist.apache.org/repos/dist/release/iceberg
6768
$ cd iceberg
68-
$ editor KEYS
69-
$ svn ci KEYS
69+
```
70+
+ Append your GPG public key to the KEYS file. Replace <YOUR_KEY_ID> with your actual GPG key ID.
71+
72+
```console
73+
$ echo "" >> KEYS # append a newline
74+
$ gpg --list-sigs <YOUR_KEY_ID> >> KEYS # append signatures
75+
$ gpg --armor --export <YOUR_KEY_ID> >> KEYS # append public key block
76+
$ svn commit -m "Add GPG key for <YOUR_NAME>"
7077
```
7178

7279
### Publish

0 commit comments

Comments
 (0)