CMake Configuration updates

Author: WillAyd

cmake_modules/IcebergBuildUtils.cmake

@@ -150,6 +150,9 @@ function(add_iceberg_lib LIB_NAME)
     target_link_libraries(${LIB_NAME}_shared
                           PUBLIC "$<BUILD_INTERFACE:iceberg_sanitizer_flags>")
 
+    string(TOUPPER ${LIB_NAME} VISIBILITY_NAME)
+    target_compile_definitions(${LIB_NAME}_shared PRIVATE ${VISIBILITY_NAME}_EXPORTING)
+
     install(TARGETS ${LIB_NAME}_shared
             EXPORT iceberg_targets
             ARCHIVE DESTINATION ${INSTALL_ARCHIVE_DIR}
@@ -208,6 +211,8 @@ function(add_iceberg_lib LIB_NAME)
     target_link_libraries(${LIB_NAME}_static
                           PUBLIC "$<BUILD_INTERFACE:iceberg_sanitizer_flags>")
 
+    string(TOUPPER ${LIB_NAME} VISIBILITY_NAME)
+    target_compile_definitions(${LIB_NAME}_static PUBLIC ${VISIBILITY_NAME}_STATIC)
     install(TARGETS ${LIB_NAME}_static
             EXPORT iceberg_targets
             ARCHIVE DESTINATION ${INSTALL_ARCHIVE_DIR}

src/iceberg/CMakeLists.txt

@@ -182,17 +182,9 @@ if(ICEBERG_BUILD_BUNDLE)
                   OUTPUTS
                   ICEBERG_BUNDLE_LIBRARIES)
 
-  foreach(LIB_TARGET ${ICEBERG_BUNDLE_LIBRARIES})
-    target_compile_definitions(${LIB_TARGET} PRIVATE ICEBERG_BUNDLE_EXPORTING)
-  endforeach()
-
-  if(ICEBERG_BUILD_STATIC)
-    target_compile_definitions(iceberg_bundle_static PUBLIC ICEBERG_BUNDLE_STATIC)
-  endif()
-
   add_subdirectory(arrow)
   add_subdirectory(avro)
   add_subdirectory(parquet)
 endif()
 
-iceberg_install_cmake_package(Iceberg iceberg_targets)
+iceberg_install_cmake_package(iceberg iceberg_targets)