fix review again

Author: HeartLinked

src/iceberg/arrow_array_reader.h

@@ -27,6 +27,7 @@
 
 namespace iceberg {
 
+/// \brief A reader interface that returns ArrowArray in a streaming fashion.
 class ICEBERG_EXPORT ArrowArrayReader {
  public:
   /// \brief Read next batch of data.

src/iceberg/table_scan.cc

@@ -19,10 +19,6 @@
 
 #include "iceberg/table_scan.h"
 
-#include <algorithm>
-#include <ranges>
-#include <utility>
-
 #include "iceberg/file_reader.h"
 #include "iceberg/manifest_entry.h"
 #include "iceberg/manifest_list.h"
@@ -59,7 +55,7 @@ Result<std::unique_ptr<ArrowArrayReader>> FileScanTask::ToArrowArrayReader(
   ICEBERG_ASSIGN_OR_RAISE(auto reader,
                           ReaderFactoryRegistry::Open(data_file_->file_format, options));
 
-  return std::move(reader);
+  return reader;
 }
 
 TableScanBuilder::TableScanBuilder(std::shared_ptr<TableMetadata> table_metadata,

src/iceberg/table_scan.h

@@ -51,21 +51,15 @@ class ICEBERG_EXPORT FileScanTask : public ScanTask {
   /// \brief The data file that should be read by this scan task.
   const std::shared_ptr<DataFile>& data_file() const;
 
-  /// \brief The total size in bytes of the file split to be read.
   int64_t size_bytes() const override;
 
-  /// \brief The number of files that should be read by this scan task.
   int32_t files_count() const override;
 
-  /// \brief The number of rows that should be read by this scan task.
   int64_t estimated_row_count() const override;
 
   /**
    * \brief Returns an ArrowArrayReader to read the data for this task.
    *
-   * This acts as a factory to instantiate a file-format-specific reader (e.g., Parquet)
-   * based on the metadata in this task and the provided parameters.
-   *
    * \param projected_schema The projected schema for reading the data.
    * \param filter Optional filter expression to apply during reading.
    * \param io The FileIO instance for accessing the file data.

test/file_scan_task_test.cc

@@ -120,9 +120,9 @@ TEST_F(FileScanTaskTest, ReadFullSchema) {
   data_file->file_path = temp_parquet_file_;
   data_file->file_format = FileFormatType::kParquet;
 
-  auto io_internal = internal::checked_cast<arrow::ArrowFileSystemFileIO&>(*file_io_);
+  auto io = internal::checked_cast<arrow::ArrowFileSystemFileIO&>(*file_io_);
   data_file->file_size_in_bytes =
-      io_internal.fs()->GetFileInfo(temp_parquet_file_).ValueOrDie().size();
+      io.fs()->GetFileInfo(temp_parquet_file_).ValueOrDie().size();
 
   auto projected_schema = std::make_shared<Schema>(
       std::vector<SchemaField>{SchemaField::MakeRequired(1, "id", int32()),
@@ -144,9 +144,9 @@ TEST_F(FileScanTaskTest, ReadProjectedAndReorderedSchema) {
   data_file->file_path = temp_parquet_file_;
   data_file->file_format = FileFormatType::kParquet;
 
-  auto io_internal = internal::checked_cast<arrow::ArrowFileSystemFileIO&>(*file_io_);
+  auto io = internal::checked_cast<arrow::ArrowFileSystemFileIO&>(*file_io_);
   data_file->file_size_in_bytes =
-      io_internal.fs()->GetFileInfo(temp_parquet_file_).ValueOrDie().size();
+      io.fs()->GetFileInfo(temp_parquet_file_).ValueOrDie().size();
 
   auto projected_schema = std::make_shared<Schema>(
       std::vector<SchemaField>{SchemaField::MakeOptional(2, "name", string()),