add license

Author: HeartLinked

cmake_modules/IcebergThirdpartyToolchain.cmake

@@ -268,6 +268,24 @@ function(resolve_cpr_dependency)
       OFF
       CACHE BOOL "" FORCE)
 
+  # Force curl to use Position Independent Code for shared library compatibility
+  set(CURL_ENABLE_PIC
+      ON
+      CACHE BOOL "" FORCE)
+
+  set(CURL_POSITION_INDEPENDENT_CODE
+      ON
+      CACHE BOOL "" FORCE)
+
+  # Additional curl PIC settings
+  set(BUILD_CURL_EXE
+      OFF
+      CACHE BOOL "" FORCE)
+
+  set(CURL_STATIC_PIC
+      ON
+      CACHE BOOL "" FORCE)
+
   fetchcontent_declare(cpr
                        ${FC_DECLARE_COMMON_OPTIONS}
                        GIT_REPOSITORY https://github.com/libcpr/cpr.git

src/iceberg/catalog/rest/rest_catalog.cc

@@ -1,12 +1,27 @@
-// In file: iceberg/catalog/rest/rest_catalog.cc
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
 
 #include "iceberg/catalog/rest/rest_catalog.h"
 
 #include <cpr/cpr.h>
 
-namespace iceberg {
-namespace catalog {
-namespace rest {
+namespace iceberg::catalog::rest {
 
 RestCatalog::RestCatalog(const std::string& base_url) : base_url_(std::move(base_url)) {}
 
@@ -18,6 +33,4 @@ cpr::Response RestCatalog::testCprIntegration() {
   return r;
 }
 
-}  // namespace rest
-}  // namespace catalog
-}  // namespace iceberg
+}  // namespace iceberg::catalog::rest

test/rest_catalog_test.cc

@@ -1,4 +1,21 @@
-// In your test file, e.g., rest_catalog_test.cc
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
 
 #include "iceberg/catalog/rest/rest_catalog.h"
 
@@ -8,9 +25,7 @@
 #include "cpr/error.h"
 #include "cpr/response.h"
 
-namespace iceberg {
-namespace catalog {
-namespace rest {
+namespace iceberg::catalog::rest {
 
 class RestCatalogTest : public ::testing::Test {};
 
@@ -37,6 +52,4 @@ TEST_F(RestCatalogTest, TestCprIntegration) {
   EXPECT_THAT(response.text, ::testing::HasSubstr("\"hello\": \"world\""));
 }
 
-}  // namespace rest
-}  // namespace catalog
-}  // namespace iceberg
+}  // namespace iceberg::catalog::rest