Skip to content

Commit e29fde1

Browse files
committed
fix pending_upate_test build error in meson windows2025
1 parent e0b35ef commit e29fde1

File tree

5 files changed

+33
-3
lines changed

5 files changed

+33
-3
lines changed

src/iceberg/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ set(ICEBERG_SOURCES
4747
partition_field.cc
4848
partition_spec.cc
4949
partition_summary.cc
50+
pending_update.cc
5051
row/arrow_array_wrapper.cc
5152
row/manifest_wrapper.cc
5253
row/partition_values.cc

src/iceberg/meson.build

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ iceberg_sources = files(
6969
'partition_field.cc',
7070
'partition_spec.cc',
7171
'partition_summary.cc',
72+
'pending_udpate.cc',
7273
'row/arrow_array_wrapper.cc',
7374
'row/manifest_wrapper.cc',
7475
'row/partition_values.cc',

src/iceberg/pending_update.cc

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
/*
2+
* Licensed to the Apache Software Foundation (ASF) under one
3+
* or more contributor license agreements. See the NOTICE file
4+
* distributed with this work for additional information
5+
* regarding copyright ownership. The ASF licenses this file
6+
* to you under the Apache License, Version 2.0 (the
7+
* "License"); you may not use this file except in compliance
8+
* with the License. You may obtain a copy of the License at
9+
*
10+
* http://www.apache.org/licenses/LICENSE-2.0
11+
*
12+
* Unless required by applicable law or agreed to in writing,
13+
* software distributed under the License is distributed on an
14+
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
15+
* KIND, either express or implied. See the License for the
16+
* specific language governing permissions and limitations
17+
* under the License.
18+
*/
19+
20+
#include "iceberg/pending_update.h"
21+
22+
namespace iceberg {
23+
24+
// Explicitly instantiate the template for test
25+
template class PendingUpdateTyped<void>;
26+
27+
} // namespace iceberg

src/iceberg/test/meson.build

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ iceberg_tests = {
4747
'table_test': {
4848
'sources': files(
4949
'json_internal_test.cc',
50+
'pending_update_test.cc',
5051
'schema_json_test.cc',
5152
'table_metadata_builder_test.cc',
5253
'table_requirement_test.cc',

src/iceberg/test/pending_update_test.cc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,16 +29,16 @@ namespace iceberg {
2929
// Mock implementation for testing the interface
3030
class MockSnapshot {};
3131

32-
class MockPendingUpdate : public PendingUpdateTyped<MockSnapshot> {
32+
class MockPendingUpdate : public PendingUpdateTyped<void> {
3333
public:
3434
MockPendingUpdate() = default;
3535

36-
Result<MockSnapshot> Apply() override {
36+
Result<void> Apply() override {
3737
if (should_fail_) {
3838
return ValidationFailed("Mock validation failed");
3939
}
4040
apply_called_ = true;
41-
return MockSnapshot{};
41+
return {};
4242
}
4343

4444
Status Commit() override {

0 commit comments

Comments
 (0)