Skip to content

Commit e31ae78

Browse files
committed
Revert "remove definition of LIB_NAME_shared_EXPORTS"
This reverts commit 24acdac.
1 parent 24acdac commit e31ae78

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

cmake_modules/BuildUtils.cmake

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -214,9 +214,7 @@ function(add_iceberg_lib LIB_NAME)
214214
# generate export header file
215215
if(BUILD_SHARED)
216216
generate_export_header(${LIB_NAME}_shared BASE_NAME ${LIB_NAME})
217-
# ${LIB_NAME}_shared_EXPORTS should be defined automatically.
218-
# See https://cmake.org/cmake/help/latest/prop_tgt/DEFINE_SYMBOL.html
219-
# target_compile_definitions(${LIB_NAME}_shared PUBLIC ${LIB_NAME}_shared_EXPORTS)
217+
target_compile_definitions(${LIB_NAME}_shared PUBLIC ${LIB_NAME}_shared_EXPORTS)
220218
if(BUILD_STATIC)
221219
string(TOUPPER ${LIB_NAME} LIB_NAME_UPPER)
222220
target_compile_definitions(${LIB_NAME}_static

0 commit comments

Comments
 (0)