Skip to content

Commit e4fd340

Browse files
committed
Try fixing Cmake Win visibility regression
1 parent 0af78aa commit e4fd340

File tree

1 file changed

+22
-2
lines changed

1 file changed

+22
-2
lines changed

src/iceberg/CMakeLists.txt

Lines changed: 22 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,17 @@ add_iceberg_lib(iceberg
9999
STATIC_INSTALL_INTERFACE_LIBS
100100
${ICEBERG_STATIC_INSTALL_INTERFACE_LIBS}
101101
SHARED_INSTALL_INTERFACE_LIBS
102-
${ICEBERG_SHARED_INSTALL_INTERFACE_LIBS})
102+
${ICEBERG_SHARED_INSTALL_INTERFACE_LIBS}
103+
OUTPUTS
104+
ICEBERG_LIBRARIES)
105+
106+
foreach(LIB_TARGET ${ICEBERG_LIBRARIES})
107+
target_compile_definitions(${LIB_TARGET} PRIVATE ICEBERG_EXPORTING)
108+
endforeach()
109+
110+
if(ICEBERG_BUILD_STATIC)
111+
target_compile_definitions(iceberg_static PUBLIC ICEBERG_STATIC)
112+
endif()
103113

104114
iceberg_install_all_headers(iceberg)
105115

@@ -168,7 +178,17 @@ if(ICEBERG_BUILD_BUNDLE)
168178
STATIC_INSTALL_INTERFACE_LIBS
169179
${ICEBERG_BUNDLE_STATIC_INSTALL_INTERFACE_LIBS}
170180
SHARED_INSTALL_INTERFACE_LIBS
171-
${ICEBERG_BUNDLE_SHARED_INSTALL_INTERFACE_LIBS})
181+
${ICEBERG_BUNDLE_SHARED_INSTALL_INTERFACE_LIBS}
182+
OUTPUTS
183+
ICEBERG_BUNDLE_LIBRARIES)
184+
185+
foreach(LIB_TARGET ${ICEBERG_BUNDLE_LIBRARIES})
186+
target_compile_definitions(${LIB_TARGET} PRIVATE ICEBERG_BUNDLE_EXPORTING)
187+
endforeach()
188+
189+
if(ICEBERG_BUILD_STATIC)
190+
target_compile_definitions(iceberg_bundle_static PUBLIC ICEBERG_BUNDLE_STATIC)
191+
endif()
172192

173193
add_subdirectory(arrow)
174194
add_subdirectory(avro)

0 commit comments

Comments
 (0)