Skip to content

Commit f48c326

Browse files
author
shuxu.li
committed
feat: static table metadata access support
1 parent 9d858bb commit f48c326

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

src/iceberg/table.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ const std::vector<std::shared_ptr<Snapshot>>& BaseTable::snapshots() const {
146146
}
147147

148148
const std::vector<std::shared_ptr<HistoryEntry>>& BaseTable::history() const {
149-
// TODO: Implement history retrieval
149+
// TODO(lishuxu): Implement history retrieval
150150
throw IcebergError("history is not supported for BaseTable now");
151151
}
152152

src/iceberg/table.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ class ICEBERG_EXPORT Table {
111111

112112
class ICEBERG_EXPORT BaseTable : public Table {
113113
public:
114-
virtual ~BaseTable() override = default;
114+
~BaseTable() override = default;
115115
BaseTable(std::string name, std::shared_ptr<TableMetadata> metadata);
116116

117117
const std::string& name() const override { return name_; }
@@ -175,7 +175,7 @@ class ICEBERG_EXPORT BaseTable : public Table {
175175

176176
class ICEBERG_EXPORT StaticTable : public BaseTable {
177177
public:
178-
virtual ~StaticTable() override = default;
178+
~StaticTable() override = default;
179179
StaticTable(std::string name, std::shared_ptr<TableMetadata> metadata)
180180
: BaseTable(std::move(name), std::move(metadata)) {}
181181

test/table_test_helper.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,13 @@ namespace iceberg {
2828

2929
class TableTestHelper {
3030
public:
31+
/// \brief Get the full path to a resource file in the test resources directory
3132
static std::string GetResourcePath(const std::string& file_name);
3233

34+
/// \brief Read a JSON file from the test resources directory
3335
static void ReadJsonFile(const std::string& file_name, std::string* content);
3436

37+
/// \brief Read table metadata from a JSON file in the test resources directory
3538
static void ReadTableMetadata(const std::string& file_name,
3639
std::unique_ptr<TableMetadata>* metadata);
3740
};

0 commit comments

Comments
 (0)