add visibility.h

Author: wgtmac

api/iceberg/puffin.h

@@ -22,9 +22,11 @@
 #include <memory>
 #include <string_view>
 
+#include "iceberg/visibility.h"
+
 namespace iceberg {
 
-class Puffin {
+class ICEBERG_EXPORT Puffin {
  public:
   virtual ~Puffin() = default;
   virtual std::string_view print() const = 0;

api/iceberg/table.h

@@ -22,9 +22,11 @@
 #include <memory>
 #include <string_view>
 
+#include "iceberg/visibility.h"
+
 namespace iceberg {
 
-class Table {
+class ICEBERG_EXPORT Table {
  public:
   virtual ~Table() = default;
   virtual std::string_view print() const = 0;

api/iceberg/visibility.h

@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#pragma once
+
+#if defined(_WIN32) || defined(__CYGWIN__)
+#  ifdef ICEBERG_STATIC
+#    define ICEBERG_EXPORT
+#  else
+#    ifdef ICEBERG_EXPORTING
+#      define ICEBERG_EXPORT __declspec(dllexport)
+#    else
+#      define ICEBERG_EXPORT __declspec(dllimport)
+#    endif
+#  endif
+#else
+#  define ICEBERG_EXPORT
+#endif

src/arrow/CMakeLists.txt

@@ -73,11 +73,11 @@ add_iceberg_lib(iceberg_arrow
                 ${ICEBERG_ARROW_SHARED_INSTALL_INTERFACE_LIBS})
 
 if(ICEBERG_BUILD_STATIC AND WIN32)
-  target_compile_definitions(iceberg_arrow_static PUBLIC ICEBERG_ARROW_STATIC)
+  target_compile_definitions(iceberg_arrow_static PUBLIC ICEBERG_STATIC)
 endif()
 
 foreach(LIB_TARGET ${ICEBERG_ARROW_LIBRARIES})
-  target_compile_definitions(${LIB_TARGET} PRIVATE ICEBERG_ARROW_EXPORTING)
+  target_compile_definitions(${LIB_TARGET} PRIVATE ICEBERG_EXPORTING)
 endforeach()
 
 install(FILES "${CMAKE_CURRENT_SOURCE_DIR}/demo_arrow.h"

src/arrow/demo_arrow.h

@@ -21,23 +21,11 @@
 
 #include <string>
 
-#ifdef _WIN32
-#  ifdef ICEBERG_ARROW_STATIC
-#    define ICEBERG_ARROW_EXPORT
-#  else
-#    ifdef ICEBERG_ARROW_EXPORTING
-#      define ICEBERG_ARROW_EXPORT __declspec(dllexport)
-#    else
-#      define ICEBERG_ARROW_EXPORT __declspec(dllimport)
-#    endif
-#  endif
-#else
-#  define ICEBERG_ARROW_EXPORT
-#endif
+#include "iceberg/visibility.h"
 
 namespace iceberg::arrow {
 
-class ICEBERG_ARROW_EXPORT DemoArrow {
+class ICEBERG_EXPORT DemoArrow {
  public:
   std::string print() const;
 };

src/core/CMakeLists.txt

@@ -21,5 +21,15 @@ set(ICEBERG_CORE_INCLUDES "${ICEBERG_API_DIR}")
 add_iceberg_lib(iceberg_core
                 SOURCES
                 ${ICEBERG_CORE_SOURCES}
+                OUTPUTS
+                ICEBERG_CORE_LIBRARIES
                 PRIVATE_INCLUDES
                 ${ICEBERG_CORE_INCLUDES})
+
+if(ICEBERG_BUILD_STATIC AND WIN32)
+  target_compile_definitions(iceberg_core_static PUBLIC ICEBERG_STATIC)
+endif()
+
+foreach(LIB_TARGET ${ICEBERG_CORE_LIBRARIES})
+  target_compile_definitions(${LIB_TARGET} PRIVATE ICEBERG_EXPORTING)
+endforeach()

src/core/demo_table.h

@@ -23,7 +23,7 @@
 
 namespace iceberg {
 
-class DemoTable : public Table {
+class ICEBERG_EXPORT DemoTable : public Table {
  public:
   DemoTable() = default;
   ~DemoTable() override = default;

src/puffin/CMakeLists.txt

@@ -21,5 +21,15 @@ set(ICEBERG_PUFFIN_INCLUDES "${ICEBERG_API_DIR}")
 add_iceberg_lib(iceberg_puffin
                 SOURCES
                 ${ICEBERG_PUFFIN_SOURCES}
+                OUTPUTS
+                ICEBERG_PUFFIN_LIBRARIES
                 PRIVATE_INCLUDES
                 ${ICEBERG_PUFFIN_INCLUDES})
+
+if(ICEBERG_BUILD_STATIC AND WIN32)
+  target_compile_definitions(iceberg_puffin_static PUBLIC ICEBERG_STATIC)
+endif()
+
+foreach(LIB_TARGET ${ICEBERG_PUFFIN_LIBRARIES})
+  target_compile_definitions(${LIB_TARGET} PRIVATE ICEBERG_EXPORTING)
+endforeach()

src/puffin/demo_puffin.h

@@ -23,7 +23,7 @@
 
 namespace iceberg {
 
-class DemoPuffin : public Puffin {
+class ICEBERG_EXPORT DemoPuffin : public Puffin {
  public:
   DemoPuffin() = default;
   ~DemoPuffin() override = default;