use c++23 std::unreachable

Author: zhjwpku

src/iceberg/CMakeLists.txt

@@ -45,7 +45,6 @@ set(ICEBERG_SOURCES
     type.cc
     util/murmurhash3_internal.cc
     util/timepoint.cc
-    util/unreachable.cc
     util/gzip_internal.cc)
 
 set(ICEBERG_STATIC_BUILD_INTERFACE_LIBS)

src/iceberg/file_format.h

@@ -23,10 +23,10 @@
 /// File format used by Iceberg.
 
 #include <string_view>
+#include <utility>
 
 #include "iceberg/iceberg_export.h"
 #include "iceberg/result.h"
-#include "iceberg/util/unreachable.h"
 
 namespace iceberg {
 
@@ -50,8 +50,7 @@ ICEBERG_EXPORT inline std::string_view ToString(FileFormatType format_type) {
     case FileFormatType::kPuffin:
       return "puffin";
   }
-  internal::Unreachable(
-      std::format("Invalid file format type: {}", static_cast<int>(format_type)));
+  std::unreachable();
 }
 
 /// \brief Convert a string to a FileFormatType

src/iceberg/json_internal.cc

@@ -25,6 +25,7 @@
 #include <regex>
 #include <type_traits>
 #include <unordered_set>
+#include <utility>
 
 #include <nlohmann/json.hpp>
 
@@ -43,7 +44,6 @@
 #include "iceberg/util/formatter.h"  // IWYU pragma: keep
 #include "iceberg/util/macros.h"
 #include "iceberg/util/timepoint.h"
-#include "iceberg/util/unreachable.h"
 
 namespace iceberg {
 
@@ -478,8 +478,7 @@ nlohmann::json ToJson(const Type& type) {
     case TypeId::kUuid:
       return "uuid";
   }
-  internal::Unreachable(
-      std::format("Unknown type id: {}", static_cast<int>(type.type_id())));
+  std::unreachable();
 }
 
 nlohmann::json ToJson(const Schema& schema) {

src/iceberg/manifest_list.h

@@ -25,12 +25,12 @@
 #include <optional>
 #include <string>
 #include <string_view>
+#include <utility>
 
 #include "iceberg/iceberg_export.h"
 #include "iceberg/result.h"
 #include "iceberg/schema_field.h"
 #include "iceberg/type.h"
-#include "iceberg/util/unreachable.h"
 
 namespace iceberg {
 
@@ -216,8 +216,7 @@ ICEBERG_EXPORT constexpr std::string_view ToString(ManifestFile::Content type) n
     case ManifestFile::Content::kDeletes:
       return "deletes";
   }
-  internal::Unreachable(
-      std::format("Unknown manifest content type: {}", static_cast<int>(type)));
+  std::unreachable();
 }
 
 /// \brief Get the relative manifest content type from name

src/iceberg/schema_util.cc

@@ -22,14 +22,14 @@
 #include <format>
 #include <string_view>
 #include <unordered_map>
+#include <utility>
 
 #include "iceberg/metadata_columns.h"
 #include "iceberg/schema.h"
 #include "iceberg/schema_util_internal.h"
 #include "iceberg/util/checked_cast.h"
 #include "iceberg/util/formatter_internal.h"
 #include "iceberg/util/macros.h"
-#include "iceberg/util/unreachable.h"
 
 namespace iceberg {
 
@@ -173,8 +173,7 @@ std::string_view ToString(FieldProjection::Kind kind) {
     case FieldProjection::Kind::kNull:
       return "null";
   }
-  internal::Unreachable(
-      std::format("Unknown field projection kind: {}", static_cast<int>(kind)));
+  std::unreachable();
 }
 
 std::string ToString(const FieldProjection& projection) {

src/iceberg/snapshot.h

@@ -23,12 +23,12 @@
 #include <string>
 #include <string_view>
 #include <unordered_map>
+#include <utility>
 #include <variant>
 
 #include "iceberg/iceberg_export.h"
 #include "iceberg/result.h"
 #include "iceberg/util/timepoint.h"
-#include "iceberg/util/unreachable.h"
 
 namespace iceberg {
 
@@ -51,8 +51,7 @@ ICEBERG_EXPORT constexpr std::string_view SnapshotRefTypeToString(
     case SnapshotRefType::kTag:
       return "tag";
   }
-  internal::Unreachable(
-      std::format("Invalid snapshot reference type: {}", static_cast<int>(type)));
+  std::unreachable();
 }
 /// \brief Get the relative snapshot reference type from name
 ICEBERG_EXPORT constexpr Result<SnapshotRefType> SnapshotRefTypeFromString(

src/iceberg/transform.cc

@@ -21,10 +21,10 @@
 
 #include <format>
 #include <regex>
+#include <utility>
 
 #include "iceberg/transform_function.h"
 #include "iceberg/type.h"
-#include "iceberg/util/unreachable.h"
 
 namespace iceberg {
 namespace {
@@ -60,8 +60,7 @@ constexpr std::string_view TransformTypeToString(TransformType type) {
     case TransformType::kVoid:
       return kVoidName;
   }
-  internal::Unreachable(
-      std::format("Unknown transform type: {}", static_cast<int>(type)));
+  std::unreachable();
 }
 
 std::shared_ptr<Transform> Transform::Identity() {
@@ -169,8 +168,7 @@ std::string Transform::ToString() const {
       return std::format("{}[{}]", TransformTypeToString(transform_type_),
                          std::get<int32_t>(param_));
   }
-  internal::Unreachable(
-      std::format("Unknown transform type: {}", static_cast<int>(transform_type_)));
+  std::unreachable();
 }
 
 TransformFunction::TransformFunction(TransformType transform_type,

src/iceberg/util/unreachable.cc

@@ -24,10 +24,11 @@
 /// Adapted from Apache Arrow
 /// https://github.com/apache/arrow/blob/main/cpp/src/arrow/visit_type_inline.h
 
+#include <utility>
+
 #include "iceberg/result.h"
 #include "iceberg/type.h"
 #include "iceberg/util/checked_cast.h"
-#include "iceberg/util/unreachable.h"
 #include "iceberg/util/visitor_generate.h"
 
 namespace iceberg {
@@ -93,7 +94,7 @@ inline auto VisitType(const Type& type, VISITOR&& visitor, ARGS&&... args)
   switch (type.type_id()) {
     ICEBERG_GENERATE_FOR_ALL_TYPES(TYPE_VISIT_INLINE);
     default:
-      internal::Unreachable("Type not implemented");
+      std::unreachable();
   }
 }