Skip to content

[CI] use version 19 of clang-tools in cpp-linter-actionΒ #41

@zhjwpku

Description

@zhjwpku

cpp-linter-action use version 14 clang-tools by default [0], while working on #40, cpp-linter-action complains about the format, I use clang-format@19 on my mac(installed by brew install clang-format), so I installed llvm@14 formula, it gives the following difference:

template <class T, class E>
 inline constexpr bool is_expected_copy_assignable_v =
-    is_copy_assignable_or_void_v<T> && is_copy_constructible_or_void_v<T> &&
-    std::is_copy_assignable_v<E> && std::is_copy_constructible_v<E> &&
+    is_copy_assignable_or_void_v<T>&& is_copy_constructible_or_void_v<T>&&
+        std::is_copy_assignable_v<E>&& std::is_copy_constructible_v<E> &&
     (is_nothrow_move_constructible_or_void_v<T> ||
      std::is_nothrow_move_constructible_v<E>);
 
 // LWG-4026
 template <class T, class E>
 inline constexpr bool is_expected_trivially_copy_assignable_v =
-    is_trivially_copy_constructible_or_void_v<T> &&
-    is_trivially_copy_assignable_or_void_v<T> && is_trivially_destructible_or_void_v<T> &&
-    std::is_trivially_copy_constructible_v<E> && std::is_trivially_copy_assignable_v<E> &&
-    std::is_trivially_destructible_v<E>;
+    is_trivially_copy_constructible_or_void_v<T>&& is_trivially_copy_assignable_or_void_v<
+        T>&& is_trivially_destructible_or_void_v<T>&&
+        std::is_trivially_copy_constructible_v<E>&&
+            std::is_trivially_copy_assignable_v<E>&& std::is_trivially_destructible_v<E>;
 

+ is version 14 while - is version 19, IMHO, version 19 seems better, so I propose adding a version: 19 to cpp-linter config, I've include this in #40. I can change back to version 14 format if we agree this is a bad idea.

[0] https://cpp-linter.github.io/cpp-linter-action/inputs-outputs/#version

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions