From ac8358bb9b39f55720a5b091b8ef46925d2fc21b Mon Sep 17 00:00:00 2001 From: "xuwei.fu" Date: Wed, 4 Jun 2025 13:23:51 +0800 Subject: [PATCH 1/2] Minor typo fixes --- src/iceberg/manifest_list.h | 2 +- src/iceberg/snapshot.h | 2 +- src/iceberg/table_metadata.h | 8 +++++--- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/iceberg/manifest_list.h b/src/iceberg/manifest_list.h index 672b36ccb..ddcc38f73 100644 --- a/src/iceberg/manifest_list.h +++ b/src/iceberg/manifest_list.h @@ -52,7 +52,7 @@ struct ICEBERG_EXPORT PartitionFieldSummary { /// values are null or NaN std::optional> upper_bound; - inline static const SchemaField kConsTainsNull = + inline static const SchemaField kContainsNull = SchemaField::MakeRequired(509, "contains_null", std::make_shared(), "True if any file has a null partition value"); inline static const SchemaField kContainsNaN = diff --git a/src/iceberg/snapshot.h b/src/iceberg/snapshot.h index 924f52247..2df6a44d1 100644 --- a/src/iceberg/snapshot.h +++ b/src/iceberg/snapshot.h @@ -234,7 +234,7 @@ struct ICEBERG_EXPORT DataOperation { struct ICEBERG_EXPORT Snapshot { static constexpr int64_t kInvalidSnapshotId = -1; - /// A unqiue long ID. + /// A unique long ID. int64_t snapshot_id; /// The snapshot ID of the snapshot's parent. Omitted for any snapshot with no parent. std::optional parent_snapshot_id; diff --git a/src/iceberg/table_metadata.h b/src/iceberg/table_metadata.h index 12483140d..9c7f37da7 100644 --- a/src/iceberg/table_metadata.h +++ b/src/iceberg/table_metadata.h @@ -69,9 +69,11 @@ struct ICEBERG_EXPORT MetadataLogEntry { /// \brief Represents the metadata for an Iceberg table /// /// Note that it only contains table metadata from the spec. Compared to the Java -/// implementation, missing pieces including: 1) Map 2) List 3) Map 4) -/// Map +/// implementation, missing pieces including: +/// (1) Map +/// (2) List +/// (3) Map +/// (4) Map struct ICEBERG_EXPORT TableMetadata { static constexpr int8_t kDefaultTableFormatVersion = 2; static constexpr int8_t kSupportedTableFormatVersion = 3; From 8be414cb1c871c3cc1beddfa9e01636674f3e088 Mon Sep 17 00:00:00 2001 From: "xuwei.fu" Date: Wed, 4 Jun 2025 13:46:02 +0800 Subject: [PATCH 2/2] Minor fix --- src/iceberg/manifest_list.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/iceberg/manifest_list.cc b/src/iceberg/manifest_list.cc index a0cf2053e..e85c42140 100644 --- a/src/iceberg/manifest_list.cc +++ b/src/iceberg/manifest_list.cc @@ -27,7 +27,7 @@ namespace iceberg { const StructType& PartitionFieldSummary::Type() { static const StructType kInstance{{ - PartitionFieldSummary::kConsTainsNull, + PartitionFieldSummary::kContainsNull, PartitionFieldSummary::kContainsNaN, PartitionFieldSummary::kLowerBound, PartitionFieldSummary::kUpperBound,