feat: RegisterTable api support for InMemoryCatalog #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix some compilation warnings. see issue (apache#118)
…che#121) Just looks like forget to use `allow_field_id_missing` in `PartitionFieldFromJson(const nlohmann::json& json, bool allow_field_id_missing)` In v1 iceberg, we should allow field_id is missing. --------- Signed-off-by: Smith Cruise <[email protected]>
…pache#123) C++20 supports rewrite candidates, see https://en.cppreference.com/w/cpp/language/overload_resolution.html#Call_to_an_overloaded_operator > For `x != y`, all member, non-member, and built-in `operator==`s found are added to the set, unless there is a matching `operator!=`.
Before implement expression, Primitive should be implemented. The spec follows: https://iceberg.apache.org/spec/#schemas-and-data-types In this patch, only few types of Literals is supported, including int, long, float, double, boolean, string and binary. TODO: * [x] Implement detail logics about comparing * [x] Implement detail logics about castTo * [x] ToString and printing logics * [x] Tests Would in other patch: * More primitive type basic supports ( maybe without decimal now ) * Implement detail logics about serialize/deserialize --------- Co-authored-by: Gang Wu <[email protected]>
- or expression - change negate return type form Result to Expression - add some tests
Signed-off-by: Junwang Zhao <[email protected]>
Literal can be used for partition values and default values
Preliminary avro datum to arrow array data conversion support: - Support projecting all primitive and nested types. - Support missing fields (reading into null values). - Support int->long and float->double promotion. - Add test cases for all primitive and nested types.
…nto feature/my-feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Since the LoadTable interface needs to return a Table object that holds a shared_from_this pointer to the catalog, I remove InMemoryCatalog inheritance from Catalog and instead directly implement the interface in InMemoryCatalog.