feat: RegisterTable support for InMemoryCatalog #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgtmac
requested changes
Jul 8, 2025
test/in_memory_catalog_test.cc
Outdated
| auto status = TableMetadataUtil::Write(*file_io_, temp_filepath_, *metadata); | ||
| EXPECT_THAT(status, IsOk()); | ||
|
|
||
| auto table = catalog_->RegisterTable(tableIdent, temp_filepath_); |
Member
There was a problem hiding this comment.
Why not directly use std::filesystem::path path{GetResourcePath("TableMetadataV2Valid.json")} to locate the file? We don't need to read and write the metadata file again.
Contributor
Author
There was a problem hiding this comment.
The table metadata organization requires a separate xx.metadata.json file to store the table metadata
wgtmac
reviewed
Jul 8, 2025
gty404
reviewed
Jul 14, 2025
lishuxu
force-pushed
the
feature/register-table
branch
from
aa35ed0 to
fa57abd
Compare
wgtmac
approved these changes
Jul 15, 2025
gty404
approved these changes
Jul 15, 2025
dongxiao1198
approved these changes
Jul 16, 2025
lishuxu
force-pushed
the
feature/register-table
branch
from
437168d to
bb1cada
Compare
lishuxu
force-pushed
the
feature/register-table
branch
from
bb1cada to
4d944db
Compare
wgtmac
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Since the LoadTable interface needs to return a Table object that holds a shared_from_this pointer to the catalog, I remove InMemoryCatalog inheritance from Catalog and instead directly implement the interface in InMemoryCatalog.