Skip to content

Conversation

@dongxiao1198
Copy link
Contributor

add operator== for manifest and manifest list

Copy link
Member

@mapleFU mapleFU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use

class T {
public:
  bool operator==(const T&) const = default;

? ( Literal can also add bool operator== default )

@dongxiao1198
Copy link
Contributor Author

Can we use

class T {
public:
  bool operator==(const T&) const = default;

? ( Literal can also add bool operator== default )

Can we use

class T {
public:
  bool operator==(const T&) const = default;

? ( Literal can also add bool operator== default )

Of course yes,but there is already have operator<=>, so..

@mapleFU
Copy link
Member

mapleFU commented Jul 17, 2025

I mean:

class Literal {
public:
+  bool operator==(const Literal& lit) const {
+     ...
+  }
};

and

class Manifest {
 // using auto generated
};

@dongxiao1198
Copy link
Contributor Author

I mean:

class Literal {
public:
+  bool operator==(const Literal& lit) const {
+     ...
+  }
};

and

class Manifest {
 // using auto generated
};

ok。。 that will be much more simple

@dongxiao1198 dongxiao1198 changed the title refactor: support operator== for manifest&list feat: support operator== for Literal/Manifest/ManifestList Jul 18, 2025
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dongxiao1198 for working on this

@Xuanwo Xuanwo merged commit 5bffdf6 into apache:main Jul 21, 2025
7 checks passed
@dongxiao1198 dongxiao1198 deleted the support_eq branch July 21, 2025 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants