Skip to content

fix: Correct BuildTable method signature #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 8, 2025
Merged

fix: Correct BuildTable method signature #163

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fa7bed9
style: Improve BuildTable signature readability
HeartLinked Aug 6, 2025
cb283e8
Update src/iceberg/catalog/in_memory_catalog.cc
HeartLinked Aug 7, 2025
0dfb013
Update src/iceberg/catalog/in_memory_catalog.h
HeartLinked Aug 7, 2025
0f7bcad
Update src/iceberg/catalog.h
HeartLinked Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/iceberg/catalog.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,15 +176,6 @@ class ICEBERG_EXPORT Catalog {
virtual Result<std::shared_ptr<Table>> RegisterTable(
const TableIdentifier& identifier, const std::string& metadata_file_location) = 0;

/// \brief Instantiate a builder to either create a table or start a create/replace
/// transaction
///
/// \param identifier a table identifier
/// \param schema a schema
/// \return the builder to create a table or start a create/replace transaction
virtual std::unique_ptr<class TableBuilder> BuildTable(
const TableIdentifier& identifier, const Schema& schema) const = 0;

/// \brief A builder used to create valid tables or start create/replace transactions
class TableBuilder {
public:
Expand Down Expand Up @@ -233,6 +224,15 @@ class ICEBERG_EXPORT Catalog {
/// \return the Transaction to create the table
virtual std::unique_ptr<Transaction> StageCreate() = 0;
};

/// \brief Instantiate a builder to either create a table or start a create/replace
/// transaction
///
/// \param identifier a table identifier
/// \param schema a schema
/// \return the builder to create a table or start a create/replace transaction
virtual std::unique_ptr<class TableBuilder> BuildTable(
const TableIdentifier& identifier, const Schema& schema) const = 0;
};

} // namespace iceberg
2 changes: 1 addition & 1 deletion src/iceberg/catalog/in_memory_catalog.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,7 @@ Result<std::shared_ptr<Table>> InMemoryCatalog::RegisterTable(
return LoadTable(identifier);
}

std::unique_ptr<TableBuilder> InMemoryCatalog::BuildTable(
std::unique_ptr<iceberg::Catalog::TableBuilder> InMemoryCatalog::BuildTable(
const TableIdentifier& identifier, const Schema& schema) const {
throw IcebergError("not implemented");
}
Expand Down
4 changes: 2 additions & 2 deletions src/iceberg/catalog/in_memory_catalog.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,8 @@ class ICEBERG_EXPORT InMemoryCatalog
const TableIdentifier& identifier,
const std::string& metadata_file_location) override;

std::unique_ptr<iceberg::TableBuilder> BuildTable(const TableIdentifier& identifier,
const Schema& schema) const override;
std::unique_ptr<iceberg::Catalog::TableBuilder> BuildTable(
const TableIdentifier& identifier, const Schema& schema) const override;

private:
std::string catalog_name_;
Expand Down
Loading