feat: read data from FileScanTask as Arrow C Stream #214
+321
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgtmac
requested changes
Sep 9, 2025
Member
|
Please also change the title to |
HeartLinked
changed the title
wgtmac
approved these changes
Sep 9, 2025
Member
My bad. There is a typo. It should be |
HeartLinked
changed the title
dongxiao1198
approved these changes
Sep 12, 2025
Fokko
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new method
FileScanTask::ToArrow()which returns a standard structArrowArrayStream. This makes iceberg-cpp a first-class citizen in the Arrow ecosystem.FileScanTask::ToArrow()is added. It takes the projected schema, filter, and FileIO as arguments to create and configure a file-format-specific reader (ParquetReader, etc.).A new factory function,
MakeArrowArrayStream, is introduced. It takes an internal C++ Reader instance and wraps it in anArrowArrayStream, correctly managing state and resource lifecycle via the C interface callbacks (get_schema,get_next,release).