fix: address feedback from initial release #223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wgtmac
commented
Sep 11, 2025
wgtmac
commented
- suppress warnings from verify_rc.sh
- fix release.sh not to rename artifacts
- refactor wordings in the email templates
- suppress warnings from verify_rc.sh - fix release.sh not to rename artifacts - refactor wordings in the email templates
wgtmac
commented
Sep 11, 2025
|
|
||
| # Configure build | ||
| cmake -S . -B build \ | ||
| -DCMAKE_CXX_FLAGS="-Wno-deprecated-declarations" \ |
Member
Author
There was a problem hiding this comment.
I have added --compile-no-warning-as-error below and this one is also required. @lidavidm
| svn co "${dist_url}/${release_id}" | ||
| pushd "${release_id}" | ||
|
|
||
| echo "Renaming artifacts to their final release names..." |
Member
Author
There was a problem hiding this comment.
We don't need this hack any more. Now artifact names do not have -rcN suffix. @HeartLinked
HeartLinked
approved these changes
Sep 11, 2025
lidavidm
approved these changes
Sep 11, 2025
Fokko
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.