feat: add CRoaring dependency #231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 16, 2025 17:00
- Integrated CRoaring library into the project by adding a new function to resolve its dependency in `IcebergThirdpartyToolchain.cmake`. - Updated the CMakeLists to include CRoaring in both static and shared build interfaces.
nullccxsy
force-pushed
the
addCRoaring
branch
from
4aa3c65 to
93d4f81
Compare
wgtmac
reviewed
Sep 17, 2025
Member
wgtmac
left a comment
wgtmac
left a comment
There was a problem hiding this comment.
Generally looks good! I've left some minor comments.
wgtmac
approved these changes
Sep 17, 2025
Fokko
approved these changes
Sep 17, 2025
Contributor
|
Thanks @nullccxsy for adding this, and thanks @wgtmac for the review 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IcebergThirdpartyToolchain.cmake.