Add China mirror support for dependencies #319
Conversation
| - CMake 3.25 or higher | ||
| - C++23 compliant compiler | ||
|
|
||
| > **Note**: For developers in China experiencing network issues when downloading dependencies, see [BUILD_CHINA.md](BUILD_CHINA.md) for mirror configuration. |
There was a problem hiding this comment.
-1 from me. sorry about that :(
One quick question: do other Apache projects handle this the same way for China?
iceberg-cpp should build against system libraries dependencies, and I think that's probably the right direction.
There was a problem hiding this comment.
Agree with you. We have CMake options such as ICEBERG_ARROW_URL which allow users to customize urls. If other projects use specific urls for China, I would also support following this approach.
There was a problem hiding this comment.
Thanks for the review!
To clarify: this PR doesn’t introduce region specific behavior or change defaults. It only provides optional mirror URLs just like ICEBERG_ARROW_URL to make the build workable for developers in China who frequently hit GitHub timeouts.
If preferred, I can simplify the PR so it only adds optional CMake variables + documentation, matching how other Apache projects handle this.
Please let me know and I’ll update it accordingly.
There was a problem hiding this comment.
Here is my -1 too. I don't think it's good idea to add other mirrors in ARROW_SOURCE_URL too.
There was a problem hiding this comment.
After researching Apache best practices I removed all hardcoded mirror URLs and kept only optional environment variables for custom mirrors just like ICEBERG_ARROW_URL. I added documentation showing how users can set these variables if needed. No defaults changed—everything still defaults to the original URLs. This keeps the build flexible respects Apache guidelines and helps developers facing network issues. Please review and let me know if you need any changes.
4 participants
Fixes #239