feat: implement expression evaluator #327
Open
+1,174
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@zhjwpku @HuaHuaY @HeartLinked PTAL |
HuaHuaY
reviewed
Nov 20, 2025
|
|
||
| class Evaluator::EvalVisitor : public BoundVisitor<bool> { | ||
| public: | ||
| void UpdateRow(const StructLike* row) { row_ = row; } |
Contributor
There was a problem hiding this comment.
I think we can create a new object in Evaluator::Eval like java's implementation and change UpdateRow to constructor. So we don't need ICEBERG_DCHECK(row_, "Row is not set") in every methods.
HuaHuaY
approved these changes
Nov 20, 2025
zhjwpku
approved these changes
Nov 20, 2025
| } | ||
|
|
||
| Result<bool> NotNull(const std::shared_ptr<BoundTerm>& term) override { | ||
| ICEBERG_DCHECK(row_, "Row is not set"); |
Collaborator
There was a problem hiding this comment.
Not a strong opinion, we could adopt the same pattern used for Eq/NotEq, where NotXXX calls XXX and returns !result. Ditto for Lt/GtEq and Gt/LtEq.
|
|
||
| class Evaluator::EvalVisitor : public BoundVisitor<bool> { | ||
| public: | ||
| void UpdateRow(const StructLike* row) { row_ = row; } |
Collaborator
There was a problem hiding this comment.
nit: SetRow? since this method doesn't update anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.