Skip to content

Commit 12729fa

Browse files
committed
removed errant files
1 parent 386cb15 commit 12729fa

File tree

3 files changed

+3
-19
lines changed

3 files changed

+3
-19
lines changed

.gitignore

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,5 +50,3 @@ htmlcov
5050
pyiceberg/avro/decoder_fast.c
5151
pyiceberg/avro/*.html
5252
pyiceberg/avro/*.so
53-
.vscode/settings.json
54-
pyiceberg/table/update/expire_snapshot.md

tests/expressions/test_literals.py

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -393,22 +393,6 @@ def test_string_to_boolean_literal() -> None:
393393
assert literal("FALSE").to(BooleanType()) == literal(False)
394394

395395

396-
def test_string_to_float_literal() -> None:
397-
assert literal("3.141").to(FloatType()) == literal(3.141).to(FloatType())
398-
399-
400-
def test_string_to_float_outside_bound() -> None:
401-
big_lit_str = literal(str(FloatType.max + 1.0e37))
402-
assert big_lit_str.to(FloatType()) == FloatAboveMax()
403-
404-
small_lit_str = literal(str(FloatType.min - 1.0e37))
405-
assert small_lit_str.to(FloatType()) == FloatBelowMin()
406-
407-
408-
def test_string_to_double_literal() -> None:
409-
assert literal("3.141").to(DoubleType()) == literal(3.141)
410-
411-
412396
@pytest.mark.parametrize(
413397
"val",
414398
["unknown", "off", "on", "0", "1", "y", "yes", "n", "no", "t", "f"],

tests/integration/test_rest_schema.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ def test_schema_evolution_via_transaction(catalog: Catalog) -> None:
154154
NestedField(field_id=4, name="col_integer", field_type=IntegerType(), required=False),
155155
)
156156

157-
with pytest.raises(CommitFailedException, match="Requirement failed: current schema id has changed: expected 2, found 3"):
157+
with pytest.raises(CommitFailedException) as exc_info:
158158
with tbl.transaction() as tx:
159159
# Start a new update
160160
schema_update = tx.update_schema()
@@ -165,6 +165,8 @@ def test_schema_evolution_via_transaction(catalog: Catalog) -> None:
165165
# stage another update in the transaction
166166
schema_update.add_column("col_double", DoubleType()).commit()
167167

168+
assert "Requirement failed: current schema changed: expected id 2 != 3" in str(exc_info.value)
169+
168170
assert tbl.schema() == Schema(
169171
NestedField(field_id=1, name="col_uuid", field_type=UUIDType(), required=False),
170172
NestedField(field_id=2, name="col_fixed", field_type=FixedType(25), required=False),

0 commit comments

Comments
 (0)