Skip to content

Commit 1339412

Browse files
authored
Fix renames of tpep_pickup_datetimetpep_pickup_day (#2496)
Follow-up of #2265 where some partition fields were renamed to avoid naming conflicts but the fixtures were not updated properly. <!-- Thanks for opening a pull request! --> <!-- In the case this PR will resolve an issue, please replace ${GITHUB_ISSUE_ID} below with the actual Github issue id. --> <!-- Closes #${GITHUB_ISSUE_ID} --> # Rationale for this change ## Are these changes tested? ## Are there any user-facing changes? <!-- In the case of user-facing changes, please add the changelog label. -->
1 parent 6b07b4a commit 1339412

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

tests/avro/test_reader.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ def test_read_header(generated_manifest_entry_file: str, iceberg_manifest_entry_
112112
{
113113
"field-id": 1001,
114114
"default": None,
115-
"name": "tpep_pickup_datetime",
115+
"name": "tpep_pickup_day",
116116
"type": ["null", {"type": "int", "logicalType": "date"}],
117117
},
118118
],

tests/conftest.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1178,7 +1178,7 @@ def metadata_location_gz(tmp_path_factory: pytest.TempPathFactory) -> str:
11781178
"data_file": {
11791179
"file_path": "/home/iceberg/warehouse/nyc/taxis_partitioned/data/VendorID=null/00000-633-d8a4223e-dc97-45a1-86e1-adaba6e8abd7-00001.parquet",
11801180
"file_format": "PARQUET",
1181-
"partition": {"VendorID": 1, "tpep_pickup_datetime": 1925},
1181+
"partition": {"VendorID": 1, "tpep_pickup_day": 1925},
11821182
"record_count": 19513,
11831183
"file_size_in_bytes": 388872,
11841184
"block_size_in_bytes": 67108864,
@@ -1677,7 +1677,7 @@ def avro_schema_manifest_entry() -> Dict[str, Any]:
16771677
{
16781678
"field-id": 1001,
16791679
"default": None,
1680-
"name": "tpep_pickup_datetime",
1680+
"name": "tpep_pickup_day",
16811681
"type": ["null", {"type": "int", "logicalType": "date"}],
16821682
},
16831683
],
@@ -1969,7 +1969,7 @@ def iceberg_manifest_entry_schema() -> Schema:
19691969
),
19701970
NestedField(
19711971
field_id=1001,
1972-
name="tpep_pickup_datetime",
1972+
name="tpep_pickup_day",
19731973
field_type=DateType(),
19741974
required=False,
19751975
),

0 commit comments

Comments
 (0)