Skip to content

Commit 3c98eef

Browse files
committed
Comments, thanks Kevin!
1 parent 8849d97 commit 3c98eef

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

pyiceberg/table/__init__.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -243,8 +243,8 @@ class TableProperties:
243243
WRITE_PARTITION_SUMMARY_LIMIT_DEFAULT = 0
244244

245245
DELETE_MODE = "write.delete.mode"
246-
DELETE_MODE_COPY_ON_WRITE = "merge-on-read"
247-
DELETE_MODE_MERGE_ON_READ = "copy-on-write"
246+
DELETE_MODE_COPY_ON_WRITE = "copy-on-write"
247+
DELETE_MODE_MERGE_ON_READ = "merge-on-read"
248248

249249
DEFAULT_NAME_MAPPING = "schema.name-mapping.default"
250250
FORMAT_VERSION = "format-version"
@@ -310,6 +310,8 @@ def _apply(self, updates: Tuple[TableUpdate, ...], requirements: Tuple[TableRequ
310310
for new_requirement in requirements:
311311
if type(new_requirement) not in existing_requirements:
312312
self._requirements = self._requirements + requirements
313+
else:
314+
warnings.warn(f"Dropped duplicate requirement: {new_requirement}")
313315

314316
self.table_metadata = update_table_metadata(self.table_metadata, updates)
315317

0 commit comments

Comments
 (0)