Skip to content

Commit 6c6df96

Browse files
smaheshwar-pltrSreesh Maheshwar
andauthored
Nit: Make DataScan::_check_sequence_number static (#2196)
<!-- Thanks for opening a pull request! --> <!-- In the case this PR will resolve an issue, please replace ${GITHUB_ISSUE_ID} below with the actual Github issue id. --> <!-- Closes #${GITHUB_ISSUE_ID} --> # Rationale for this change Silence PyCharm warning that `DataScan::_check_sequence_number` can be static. # Are these changes tested? N/A # Are there any user-facing changes? No <!-- In the case of user-facing changes, please add the changelog label. --> Co-authored-by: Sreesh Maheshwar <[email protected]>
1 parent 479e663 commit 6c6df96

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

pyiceberg/table/__init__.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1857,7 +1857,8 @@ def _build_residual_evaluator(self, spec_id: int) -> Callable[[DataFile], Residu
18571857
)
18581858
)
18591859

1860-
def _check_sequence_number(self, min_sequence_number: int, manifest: ManifestFile) -> bool:
1860+
@staticmethod
1861+
def _check_sequence_number(min_sequence_number: int, manifest: ManifestFile) -> bool:
18611862
"""Ensure that no manifests are loaded that contain deletes that are older than the data.
18621863
18631864
Args:

0 commit comments

Comments
 (0)