Skip to content

Commit 7837d52

Browse files
authored
Docs: Remove -s and add key publishing steps (#576)
1 parent 90e5057 commit 7837d52

File tree

1 file changed

+13
-3
lines changed

1 file changed

+13
-3
lines changed

mkdocs/docs/how-to-release.md

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,17 @@ export GIT_TAG_HASH=${GIT_TAG_REF:0:40}
5656
export LAST_COMMIT_ID=$(git rev-list ${GIT_TAG} 2> /dev/null | head -n 1)
5757
```
5858

59-
The `-s` option will sign the commit. If you don't have a key yet, you can find the instructions [here](http://www.apache.org/dev/openpgp.html#key-gen-generate-key). To install gpg on a M1 based Mac, a couple of additional steps are required: https://gist.github.com/phortuin/cf24b1cca3258720c71ad42977e1ba57
59+
The `-s` option will sign the commit. If you don't have a key yet, you can find the instructions [here](http://www.apache.org/dev/openpgp.html#key-gen-generate-key). To install gpg on a M1 based Mac, a couple of additional steps are required: https://gist.github.com/phortuin/cf24b1cca3258720c71ad42977e1ba57.
60+
If you have not published your GPG key in [KEYS](https://dist.apache.org/repos/dist/dev/iceberg/KEYS) yet, you must publish it before sending the vote email by doing:
61+
62+
```bash
63+
svn co https://dist.apache.org/repos/dist/dev/iceberg icebergsvn
64+
cd icebergsvn
65+
echo "" >> KEYS # append a newline
66+
gpg --list-sigs <YOUR KEY ID HERE> >> KEYS # append signatures
67+
gpg --armor --export <YOUR KEY ID HERE> >> KEYS # append public key block
68+
svn commit -m "add key for <YOUR NAME HERE>"
69+
```
6070

6171
### Upload to Apache SVN
6272

@@ -96,7 +106,7 @@ Go to Github Actions and run the `Python release` action. Set the version of the
96106
Next step is to upload them to pypi. Please keep in mind that this **won't** bump the version for everyone that hasn't pinned their version, since it is set to an RC [pre-release and those are ignored](https://packaging.python.org/en/latest/guides/distributing-packages-using-setuptools/#pre-release-versioning).
97107

98108
```bash
99-
twine upload -s release-0.1.0rc1/*
109+
twine upload release-0.1.0rc1/*
100110
```
101111

102112
Final step is to generate the email to the dev mail list:
@@ -176,7 +186,7 @@ svn ci -m "PyIceberg <VERSION>" /tmp/iceberg-dist-release/
176186
The latest version can be pushed to PyPi. Check out the Apache SVN and make sure to publish the right version with `twine`:
177187

178188
```bash
179-
twine upload -s /tmp/iceberg-dist-release/pyiceberg-<VERSION>/*
189+
twine upload /tmp/iceberg-dist-release/pyiceberg-<VERSION>/*
180190
```
181191

182192
Send out an announcement on the dev mail list:

0 commit comments

Comments
 (0)