Skip to content

Commit acbdeca

Browse files
authored
Run test_create_table_transaction for Rest V1 tables (#2137)
<!-- Thanks for opening a pull request! --> <!-- In the case this PR will resolve an issue, please replace ${GITHUB_ISSUE_ID} below with the actual Github issue id. --> <!-- Closes #${GITHUB_ISSUE_ID} --> # Rationale for this change Moar test coverage :) # Are these changes tested? # Are there any user-facing changes? <!-- In the case of user-facing changes, please add the changelog label. -->
1 parent e937f6a commit acbdeca

File tree

1 file changed

+0
-11
lines changed

1 file changed

+0
-11
lines changed

tests/integration/test_writes/test_writes.py

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@
4040

4141
from pyiceberg.catalog import Catalog, load_catalog
4242
from pyiceberg.catalog.hive import HiveCatalog
43-
from pyiceberg.catalog.rest import RestCatalog
4443
from pyiceberg.catalog.sql import SqlCatalog
4544
from pyiceberg.exceptions import NoSuchTableError
4645
from pyiceberg.expressions import And, EqualTo, GreaterThanOrEqual, In, LessThan, Not
@@ -885,11 +884,6 @@ def test_write_and_evolve(session_catalog: Catalog, format_version: int) -> None
885884
@pytest.mark.parametrize("format_version", [1, 2])
886885
@pytest.mark.parametrize("catalog", [pytest.lazy_fixture("session_catalog_hive"), pytest.lazy_fixture("session_catalog")])
887886
def test_create_table_transaction(catalog: Catalog, format_version: int) -> None:
888-
if format_version == 1 and isinstance(catalog, RestCatalog):
889-
pytest.skip(
890-
"There is a bug in the REST catalog image (https://github.com/apache/iceberg/issues/8756) that prevents create and commit a staged version 1 table"
891-
)
892-
893887
identifier = f"default.arrow_create_table_transaction_{catalog.name}_{format_version}"
894888

895889
try:
@@ -942,11 +936,6 @@ def test_create_table_transaction(catalog: Catalog, format_version: int) -> None
942936
@pytest.mark.parametrize("format_version", [1, 2])
943937
@pytest.mark.parametrize("catalog", [pytest.lazy_fixture("session_catalog_hive"), pytest.lazy_fixture("session_catalog")])
944938
def test_create_table_with_non_default_values(catalog: Catalog, table_schema_with_all_types: Schema, format_version: int) -> None:
945-
if format_version == 1 and isinstance(catalog, RestCatalog):
946-
pytest.skip(
947-
"There is a bug in the REST catalog image (https://github.com/apache/iceberg/issues/8756) that prevents create and commit a staged version 1 table"
948-
)
949-
950939
identifier = f"default.arrow_create_table_transaction_with_non_default_values_{catalog.name}_{format_version}"
951940
identifier_ref = f"default.arrow_create_table_transaction_with_non_default_values_ref_{catalog.name}_{format_version}"
952941

0 commit comments

Comments
 (0)