Skip to content

Commit d6011e6

Browse files
authored
visual aids (#975)
Co-authored-by: Sung Yun <[email protected]>
1 parent 266c1cc commit d6011e6

File tree

3 files changed

+10
-4
lines changed

3 files changed

+10
-4
lines changed
216 KB
Loading
214 KB
Loading

mkdocs/docs/how-to-release.md

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ Set the tag on the last commit:
5858

5959
```bash
6060
export RC=rc1
61-
export VERSION=0.1.0${RC}
61+
export VERSION=0.7.0${RC}
6262
export VERSION_WITHOUT_RC=${VERSION/rc?/}
6363
export VERSION_BRANCH=${VERSION_WITHOUT_RC//./-}
6464
export GIT_TAG=pyiceberg-${VERSION}
@@ -89,7 +89,11 @@ Both the source distribution (`sdist`) and the binary distributions (`wheels`) n
8989

9090
Before committing the files to the Apache SVN artifact distribution SVN hashes need to be generated, and those need to be signed with gpg to make sure that they are authentic.
9191

92-
Go to [Github Actions and run the `Python release` action](https://github.com/apache/iceberg-python/actions/workflows/python-release.yml). **Set the version to main, since we cannot modify the source**. Download the zip, and sign the files:
92+
Go to [Github Actions and run the `Python release` action](https://github.com/apache/iceberg-python/actions/workflows/python-release.yml). **Set the version to main, since we cannot modify the source**.
93+
94+
![Github Actions Run Workflow for SVN Upload](assets/images/ghactions-run-workflow-svn-upload.png)
95+
96+
Download the zip, and sign the files:
9397

9498
```bash
9599
cd release-main/
@@ -116,12 +120,14 @@ svn ci -m "PyIceberg ${VERSION}" ${SVN_TMP_DIR_VERSIONED}
116120

117121
### Upload to PyPi
118122

119-
Go to Github Actions and run the `Python release` action. Set the version of the release candidate as the input: `0.1.0rc1`. Download the zip and unzip it locally.
123+
Go to Github Actions and run the `Python release` action again. This time, set the **version** of the release candidate as the input: e.g. `0.7.0rc1`. Download the zip and unzip it locally.
124+
125+
![Github Actions Run Workflow for PyPi Upload](assets/images/ghactions-run-workflow-pypi-upload.png)
120126

121127
Next step is to upload them to pypi. Please keep in mind that this **won't** bump the version for everyone that hasn't pinned their version, since it is set to an RC [pre-release and those are ignored](https://packaging.python.org/en/latest/guides/distributing-packages-using-setuptools/#pre-release-versioning).
122128

123129
```bash
124-
twine upload release-0.1.0rc1/*
130+
twine upload release-0.7.0rc1/*
125131
```
126132

127133
Final step is to generate the email to the dev mail list:

0 commit comments

Comments
 (0)