rename api to latest_snapshot_before_timestamp

Author: chinmay-bhat

pyiceberg/table/__init__.py

@@ -1290,9 +1290,9 @@ def snapshot_by_name(self, name: str) -> Optional[Snapshot]:
             return self.snapshot_by_id(ref.snapshot_id)
         return None
 
-    def snapshot_by_timestamp(self, timestamp_ms: int) -> Optional[Snapshot]:
+    def latest_snapshot_before_timestamp(self, timestamp_ms: int) -> Optional[Snapshot]:
         """Get the snapshot right before the given timestamp, or None if there is no matching snapshot."""
-        return self.metadata.snapshot_by_timestamp(timestamp_ms)
+        return self.metadata.latest_snapshot_before_timestamp(timestamp_ms)
 
     def history(self) -> List[SnapshotLogEntry]:
         """Get the snapshot history of this table."""

pyiceberg/table/metadata.py

@@ -230,7 +230,7 @@ def snapshot_by_id(self, snapshot_id: int) -> Optional[Snapshot]:
         """Get the snapshot by snapshot_id."""
         return next((snapshot for snapshot in self.snapshots if snapshot.snapshot_id == snapshot_id), None)
 
-    def snapshot_by_timestamp(self, timestamp_ms: int) -> Optional[Snapshot]:
+    def latest_snapshot_before_timestamp(self, timestamp_ms: int) -> Optional[Snapshot]:
         """Get the snapshot right before the given timestamp."""
         result, prev_timestamp = None, 0
         for snapshot in self.snapshots:

tests/table/test_init.py

@@ -205,7 +205,7 @@ def test_snapshot_by_id(table_v2: Table) -> None:
 
 
 def test_snapshot_by_timestamp(table_v2: Table) -> None:
-    assert table_v2.snapshot_by_timestamp(1555100955771) == Snapshot(
+    assert table_v2.latest_snapshot_before_timestamp(1555100955771) == Snapshot(
         snapshot_id=3055729675574597004,
         parent_snapshot_id=3051729675574597004,
         sequence_number=1,