Apply suggestions from code review

Xuanwo · lidavidm · web-flow · commit 149220699b46 · 2025-03-06T16:50:44.000+08:00
Co-authored-by: David Li &lt;li.davidm96@gmail.com&gt;
diff --git a/bindings/c/CMakeLists.txt b/bindings/c/CMakeLists.txt
@@ -43,7 +43,7 @@ message(NOTICE "-- Iceberg C shared lib: ${ICEBERG_SHARED_LIB}")
 
 # custom target for cargo build
 add_custom_target(cargo_build
-    COMMAND sh -c "cargo build ${CARGO_BUILD_TYPE}"
+    COMMAND cargo build ${CARGO_BUILD_TYPE}
     BYPRODUCTS  ${ICEBERG_STATIC_LIB} ${ICEBERG_SHARED_LIB}
     WORKING_DIRECTORY ${PROJECT_SOURCE_DIR}
 )

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ message(NOTICE "-- Iceberg C shared lib: ${ICEBERG_SHARED_LIB}")`
`43`	`43`
`44`	`44`	`# custom target for cargo build`
`45`	`45`	`add_custom_target(cargo_build`
`46`		`- COMMAND sh -c "cargo build ${CARGO_BUILD_TYPE}"`
	`46`	`+ COMMAND cargo build ${CARGO_BUILD_TYPE}`
`47`	`47`	`BYPRODUCTS ${ICEBERG_STATIC_LIB} ${ICEBERG_SHARED_LIB}`
`48`	`48`	`WORKING_DIRECTORY ${PROJECT_SOURCE_DIR}`
`49`	`49`	`)`