Skip to content

Commit 79f28ff

Browse files
authored
fix: await get catalog in datafusion integration test (#1635)
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> - Closes #. ## What changes are included in this PR? <!-- Provide a summary of the modifications in this PR. List the main changes such as new features, bug fixes, refactoring, or any other updates. --> * Previous #1600 added few integration tests, but need to include the new changes introduced in memory catalog loader change #1623 . * This caused build failures ## Are these changes tested? Yes, existing tests <!-- Specify what test covers (unit test, integration test, etc.). If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? -->
1 parent 3e6779e commit 79f28ff

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

bindings/python/pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ python-source = "python"
4444
ignore = ["F403", "F405"]
4545

4646
[tool.hatch.envs.dev]
47-
dependencies = ["maturin>=1.0,<2.0", "pytest>=8.3.2", "pyarrow>=17.0.0", "datafusion>=45", "pyiceberg[sql-sqlite]>=0.9.1"]
47+
dependencies = ["maturin>=1.0,<2.0", "pytest>=8.3.2", "pyarrow==16.*", "datafusion==47.*", "pyiceberg[sql-sqlite]>=0.9.1"]
4848

4949
[tool.hatch.envs.dev.scripts]
5050
build = "maturin build --out dist --sdist"

bindings/python/tests/test_datafusion_table_provider.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@
2727
import datafusion
2828

2929
assert (
30-
datafusion.__version__ >= "45"
31-
) # iceberg table provider only works for datafusion >= 45
30+
datafusion.__version__ >= "47"
31+
) # iceberg table provider only works for datafusion >= 47
3232

3333

3434
@pytest.fixture(scope="session")

crates/integrations/datafusion/tests/integration_datafusion_test.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -440,7 +440,7 @@ async fn test_metadata_table() -> Result<()> {
440440

441441
#[tokio::test]
442442
async fn test_insert_into() -> Result<()> {
443-
let iceberg_catalog = get_iceberg_catalog();
443+
let iceberg_catalog = get_iceberg_catalog().await;
444444
let namespace = NamespaceIdent::new("test_insert_into".to_string());
445445
set_test_namespace(&iceberg_catalog, &namespace).await?;
446446

@@ -553,7 +553,7 @@ fn get_nested_struct_type() -> StructType {
553553

554554
#[tokio::test]
555555
async fn test_insert_into_nested() -> Result<()> {
556-
let iceberg_catalog = get_iceberg_catalog();
556+
let iceberg_catalog = get_iceberg_catalog().await;
557557
let namespace = NamespaceIdent::new("test_insert_nested".to_string());
558558
set_test_namespace(&iceberg_catalog, &namespace).await?;
559559
let table_name = "nested_table";

0 commit comments

Comments
 (0)