You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
infra: use toml-cli to manually set version in github action (#1537)
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax. For example
`Closes#123` indicates that this PR will close issue #123.
-->
- Closes #.
## What changes are included in this PR?
See
[comment](#1331 (comment))
for context
Previously used `cargo-edit` but it does not allow setting version from
`0.6.0` -> `0.6.0-rc1`.
This PR changes the github action to use `toml-cli` to manually override
and set the version in the `binding/python/Cargo.toml` so that we can
build pre-release artifacts to push to pypi.
<!--
Provide a summary of the modifications in this PR. List the main changes
such as new features, bug fixes, refactoring, or any other updates.
-->
## Are these changes tested?
<!--
Specify what test covers (unit test, integration test, etc.).
If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->
Yes, similar to #1449
Pushed this PR as the `main` branch in my fork
Create a new tag and push to fork to trigger CI
```
git tag "v0.6.0-rc.2" -m "v0.6.0-rc.2"
git push kevinjqliu v0.6.0-rc.2
```
Verify that python artifacts are build correctly with pre-release tag,
https://github.com/kevinjqliu/iceberg-rust/actions/runs/16436181005
- downloaded `wheels-sdist`, verified correct version in `PKG-INFO` but
not in `Cargo.toml`. I think this is fine
- downloaded `wheels-ubuntu-latest-armv7l` and verified the `METADATA`
file
0 commit comments