Make no default feature happy

Signed-off-by: Xuanwo <[email protected]>

Author: Xuanwo

crates/iceberg/Cargo.toml

@@ -29,7 +29,7 @@ license = { workspace = true }
 repository = { workspace = true }
 
 [features]
-default = ["storage-memory", "storage-fs", "storage-s3", "tokio"]
+default = ["storage-memory", "storage-fs", "storage-s3"]
 storage-all = ["storage-memory", "storage-fs", "storage-s3", "storage-gcs"]
 
 storage-azdls = ["opendal/services-azdls"]
@@ -39,7 +39,6 @@ storage-memory = ["opendal/services-memory"]
 storage-oss = ["opendal/services-oss"]
 storage-s3 = ["opendal/services-s3", "reqsign"]
 
-tokio = ["tokio/rt-multi-thread"]
 
 [dependencies]
 anyhow = { workspace = true }

crates/iceberg/src/io/storage.rs

@@ -15,6 +15,12 @@
 // specific language governing permissions and limitations
 // under the License.
 
+#[cfg(any(
+    feature = "storage-s3",
+    feature = "storage-gcs",
+    feature = "storage-oss",
+    feature = "storage-azdls",
+))]
 use std::sync::Arc;
 
 use opendal::layers::RetryLayer;
@@ -71,6 +77,7 @@ impl Storage {
     /// Convert iceberg config to opendal config.
     pub(crate) fn build(file_io_builder: FileIOBuilder) -> crate::Result<Self> {
         let (scheme_str, props, extensions) = file_io_builder.into_parts();
+        let _ = (&props, &extensions);
         let scheme = Self::parse_scheme(&scheme_str)?;
 
         match scheme {
@@ -127,6 +134,7 @@ impl Storage {
         path: &'a impl AsRef<str>,
     ) -> crate::Result<(Operator, &'a str)> {
         let path = path.as_ref();
+        let _ = path;
         let (operator, relative_path): (Operator, &str) = match self {
             #[cfg(feature = "storage-memory")]
             Storage::Memory(op) => {

crates/iceberg/src/lib.rs

@@ -66,10 +66,6 @@
 extern crate derive_builder;
 extern crate core;
 
-// Tokio runtime is mandatory for now; surface a clear build error if disabled.
-#[cfg(not(feature = "tokio"))]
-compile_error!("feature \"tokio\" must be enabled for iceberg runtime support");
-
 mod error;
 pub use error::{Error, ErrorKind, Result};
 

crates/iceberg/src/runtime/mod.rs

@@ -17,11 +17,6 @@
 
 // This module contains the async runtime abstraction for iceberg.
 
-// The crate currently mandates Tokio as the runtime. Failing early keeps build errors clear
-// when users try to disable the default runtime.
-#[cfg(not(feature = "tokio"))]
-compile_error!("feature \"tokio\" is required for async runtime");
-
 use std::future::Future;
 use std::pin::Pin;
 use std::task::{Context, Poll};