Update error type from DataInvalid to Unexpected

aditya-subrahmanyan · web-flow · commit b878844239e6 · 2026-01-05T11:07:42.000-08:00
Addresses a PR review comment to use the right error type that is aligned with the sort spec implementation
diff --git a/crates/iceberg/src/spec/table_metadata.rs b/crates/iceberg/src/spec/table_metadata.rs
@@ -511,7 +511,7 @@ impl TableMetadata {
             && !sort_order.fields.is_empty()
         {
             return Err(Error::new(
-                ErrorKind::DataInvalid,
+                ErrorKind::Unexpected,
                 format!(
                     "Sort order ID {} is reserved for unsorted order",
                     SortOrder::UNSORTED_ORDER_ID

Original file line number	Diff line number	Diff line change
`@@ -511,7 +511,7 @@ impl TableMetadata {`
`511`	`511`	`&& !sort_order.fields.is_empty()`
`512`	`512`	`{`
`513`	`513`	`return Err(Error::new(`
`514`		`- ErrorKind::DataInvalid,`
	`514`	`+ ErrorKind::Unexpected,`
`515`	`515`	`format!(`
`516`	`516`	`"Sort order ID {} is reserved for unsorted order",`
`517`	`517`	`SortOrder::UNSORTED_ORDER_ID`