refine: make commit more general (#1048)

ZENOTME · web-flow · commit e4ca87113599 · 2025-03-08T17:21:43.000+08:00
## Which issue does this PR close?

- Closes 

## What changes are included in this PR?


change the input param type of commit to make it more general. I think
the performance impact for this is minor.

## Are these changes tested?



Co-authored-by: ZENOTME &lt;st810918843@gmail.com&gt;
diff --git a/crates/iceberg/src/transaction.rs b/crates/iceberg/src/transaction.rs
@@ -163,7 +163,7 @@ impl<'a> Transaction<'a> {
     }
 
     /// Commit transaction.
-    pub async fn commit(self, catalog: &impl Catalog) -> Result<Table> {
+    pub async fn commit(self, catalog: &dyn Catalog) -> Result<Table> {
         let table_commit = TableCommit::builder()
             .ident(self.table.identifier().clone())
             .updates(self.updates)

Original file line number	Diff line number	Diff line change
`@@ -163,7 +163,7 @@ impl<'a> Transaction<'a> {`
`163`	`163`	`}`
`164`	`164`
`165`	`165`	`/// Commit transaction.`
`166`		`- pub async fn commit(self, catalog: &impl Catalog) -> Result<Table> {`
	`166`	`+ pub async fn commit(self, catalog: &dyn Catalog) -> Result<Table> {`
`167`	`167`	`let table_commit = TableCommit::builder()`
`168`	`168`	`.ident(self.table.identifier().clone())`
`169`	`169`	`.updates(self.updates)`