move use statements to top level

Author: emkornfield

crates/iceberg/src/scan/mod.rs

@@ -565,7 +565,7 @@ pub mod tests {
     //! shared tests for the table scan API
     #![allow(missing_docs)]
 
-    use std::collections::HashMap;
+    use std::collections::{HashMap, HashSet};
     use std::fs;
     use std::fs::File;
     use std::sync::Arc;
@@ -1916,8 +1916,6 @@ pub mod tests {
 
     #[tokio::test]
     async fn test_select_with_file_column() {
-        use arrow_array::cast::AsArray;
-
         let mut fixture = TableTestFixture::new();
         fixture.setup_manifest_files().await;
 
@@ -2039,8 +2037,6 @@ pub mod tests {
 
     #[tokio::test]
     async fn test_file_column_with_multiple_files() {
-        use std::collections::HashSet;
-
         let mut fixture = TableTestFixture::new();
         fixture.setup_manifest_files().await;
 

crates/iceberg/src/spec/manifest/writer.rs

@@ -572,7 +572,11 @@ mod tests {
 
     use super::*;
     use crate::io::FileIOBuilder;
-    use crate::spec::{DataFileFormat, Manifest, NestedField, PrimitiveType, Schema, Struct, Type};
+    use crate::spec::{
+        DataContentType, DataFileBuilder, DataFileFormat, Manifest, ManifestContentType,
+        ManifestEntry, ManifestMetadata, ManifestStatus, NestedField, PartitionSpec, PrimitiveType,
+        Schema, Struct, Type,
+    };
 
     #[tokio::test]
     async fn test_add_delete_existing() {
@@ -727,16 +731,6 @@ mod tests {
 
     #[tokio::test]
     async fn test_manifest_writer_with_compression() {
-        use std::fs;
-
-        use tempfile::TempDir;
-
-        use crate::io::FileIOBuilder;
-        use crate::spec::{
-            DataContentType, DataFileBuilder, DataFileFormat, ManifestContentType, ManifestEntry,
-            ManifestMetadata, ManifestStatus, NestedField, PartitionSpec, PrimitiveType, Schema,
-        };
-
         let metadata = {
             let schema = Schema::builder()
                 .with_fields(vec![Arc::new(NestedField::required(

crates/iceberg/src/spec/manifest_list.rs

@@ -1373,12 +1373,13 @@ pub(super) mod _serde {
 mod test {
     use std::fs;
 
-    use apache_avro::{Codec, Reader, Schema};
+    use apache_avro::{Codec, DeflateSettings, Reader, Schema};
+    use miniz_oxide::deflate::CompressionLevel;
     use tempfile::TempDir;
 
     use super::_serde::ManifestListV2;
     use crate::io::FileIOBuilder;
-    use crate::spec::manifest_list::_serde::{ManifestListV1, ManifestListV3};
+    use crate::spec::manifest_list::_serde::{ManifestFileV1, ManifestListV1, ManifestListV3};
     use crate::spec::{
         Datum, FieldSummary, ManifestContentType, ManifestFile, ManifestList, ManifestListWriter,
         UNASSIGNED_SEQUENCE_NUMBER,
@@ -2020,8 +2021,6 @@ mod test {
 
     #[test]
     fn test_manifest_file_v1_to_v2_projection() {
-        use crate::spec::manifest_list::_serde::ManifestFileV1;
-
         // Create a V1 manifest file object (without V2 fields)
         let v1_manifest = ManifestFileV1 {
             manifest_path: "/test/manifest.avro".to_string(),
@@ -2133,8 +2132,6 @@ mod test {
             .to_str()
             .unwrap()
             .to_string();
-        use apache_avro::DeflateSettings;
-        use miniz_oxide::deflate::CompressionLevel;
 
         let compression = Codec::Deflate(DeflateSettings::new(CompressionLevel::BestCompression));
         let mut writer = ManifestListWriter::v2(