Skip to content

Commit efbe337

Browse files
Address comments
1 parent 472141e commit efbe337

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

crates/iceberg/src/delete_file_index.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ impl PopulatedDeleteFileIndex {
115115
///
116116
/// 1. The partition information is extracted from each delete file's manifest entry.
117117
/// 2. If the partition is empty and the delete file is not a positional delete,
118-
/// it is added to the `global_deletes` vector
118+
/// it is added to the `global_equality_deletes` vector
119119
/// 3. Otherwise, the delete file is added to one of two hash maps based on its content type.
120120
fn new(files: Vec<DeleteFileContext>) -> PopulatedDeleteFileIndex {
121121
let mut eq_deletes_by_partition: HashMap<Struct, Vec<Arc<DeleteFileContext>>> =
@@ -436,8 +436,8 @@ mod tests {
436436

437437
fn build_partitioned_pos_delete(partition: &Struct, spec_id: i32) -> DataFile {
438438
DataFileBuilder::default()
439-
.file_path(format!("{}-dv.puffin", Uuid::new_v4()))
440-
.file_format(DataFileFormat::Puffin)
439+
.file_path(format!("{}-pos-delete.parquet", Uuid::new_v4()))
440+
.file_format(DataFileFormat::Parquet)
441441
.content(DataContentType::PositionDeletes)
442442
.record_count(1)
443443
.referenced_data_file(Some("/some-data-file.parquet".to_string()))

0 commit comments

Comments
 (0)