Skip to content

Commit 7361e6f

Browse files
authored
fix(ci): ensure SDK e2e tests fail when server build fails (#2509)
1 parent 6205f35 commit 7361e6f

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

.github/actions/go/pre-merge/action.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,10 +119,15 @@ runs:
119119
# Build the module
120120
go build -v ./...
121121
122+
- name: Setup Rust with cache for e2e
123+
if: inputs.task == 'e2e'
124+
uses: ./.github/actions/utils/setup-rust-with-cache
125+
with:
126+
cache-targets: false
127+
122128
- name: Setup server for e2e tests
123129
if: inputs.task == 'e2e'
124130
uses: ./.github/actions/utils/server-start
125-
continue-on-error: true
126131

127132
- name: Run e2e tests
128133
shell: bash

.github/actions/java-gradle/pre-merge/action.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@ runs:
7171
if: inputs.task == 'test'
7272
id: iggy
7373
uses: ./.github/actions/utils/server-start
74-
continue-on-error: true
7574

7675
- name: Test
7776
if: inputs.task == 'test'
@@ -97,7 +96,7 @@ runs:
9796
fi
9897
9998
- name: Stop Iggy server
100-
if: inputs.task == 'test'
99+
if: always() && inputs.task == 'test'
101100
uses: ./.github/actions/utils/server-stop
102101
with:
103102
pid-file: ${{ steps.iggy.outputs.pid_file }}

.github/actions/node-npm/pre-merge/action.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,6 @@ runs:
8686
uses: ./.github/actions/utils/server-start
8787
env:
8888
IGGY_CLUSTER_ENABLED: true
89-
continue-on-error: true
9089

9190
- name: E2E tests
9291
if: inputs.task == 'e2e'
@@ -99,7 +98,7 @@ runs:
9998
shell: bash
10099

101100
- name: Stop Iggy server
102-
if: inputs.task == 'e2e'
101+
if: always() && inputs.task == 'e2e'
103102
uses: ./.github/actions/utils/server-stop
104103
with:
105104
pid-file: ${{ steps.iggy.outputs.pid_file }}

0 commit comments

Comments
 (0)